components/sync_sessions/revisit/page_revisit_broadcaster.cc - Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_sessions/revisit/page_revisit_broadcaster.cc

Issue 2257793002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_sessions/revisit/bookmarks_page_revisit_observer_unittest.cc ('k') | components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_sessions/revisit/page_revisit_broadcaster.cc

diff --git a/components/sync_sessions/revisit/page_revisit_broadcaster.cc b/components/sync_sessions/revisit/page_revisit_broadcaster.cc

index 66fe702c596e8f02bf23af27148f6795eeb6dc19..619874538a03d4c293183fef43458667f071c9f0 100644

--- a/components/sync_sessions/revisit/page_revisit_broadcaster.cc

+++ b/components/sync_sessions/revisit/page_revisit_broadcaster.cc

@@ -54,7 +54,7 @@ PageRevisitBroadcaster::PageRevisitBroadcaster(

bool shouldInstrument = group_name == "Enabled";

if (shouldInstrument) {

revisit_observers_.push_back(new sync_sessions::SessionsPageRevisitObserver(

- base::WrapUnique(new SessionsSyncManagerWrapper(manager))));

+ base::MakeUnique<SessionsSyncManagerWrapper>(manager)));

history::HistoryService* history = sessions_client_->GetHistoryService();

if (history) {

@@ -65,8 +65,9 @@ PageRevisitBroadcaster::PageRevisitBroadcaster(

bookmarks::BookmarkModel* bookmarks = sessions_client_->GetBookmarkModel();

if (bookmarks) {

revisit_observers_.push_back(

- new sync_sessions::BookmarksPageRevisitObserver(base::WrapUnique(

- new sync_sessions::BookmarksByUrlProviderImpl(bookmarks))));

+ new sync_sessions::BookmarksPageRevisitObserver(

+ base::MakeUnique<sync_sessions::BookmarksByUrlProviderImpl>(

+ bookmarks)));

}