Add signal strength indicator icon to WebBluetooth chooser on Mac

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm

Index: chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
diff --git a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
index 0ef8a21102df7851749edab6cdfbd56d9a0c83dd..34c33d43556e0add4fe5f0f12077251dcd480a74 100644
--- a/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
+++ b/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm
@@ -45,10 +45,10 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
   return [chooserContentView_ numberOfOptions];
 }
 
-- (id)tableView:(NSTableView*)tableView
-    objectValueForTableColumn:(NSTableColumn*)tableColumn
-                          row:(NSInteger)rowIndex {
-  return [chooserContentView_ optionAtIndex:rowIndex];
+- (NSView*)tableView:(NSTableView*)tableView
+    viewForTableColumn:(NSTableColumn*)tableColumn

[Jeffrey Yasskin, 2016/08/19 18:30:05]

Another dumb question: why does this take a tableView and tableColumn that it
doesn't use?

[juncai, 2016/08/22 19:18:20]

https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/TableV...

https://developer.apple.com/library/mac/documentation/Cocoa/Reference/NSTable...:

I guess it is like a virtual function that user needs to implement to customize
the table view, and the virtual function's signature is fixed.

[Jeffrey Yasskin, 2016/08/22 21:59:24]

Yep, that's it. I missed that it was implementing a protocol. It'd be nice if
Chrome had a convention for documenting the protocols a class is implementing,
but if we don't, it's not worth inventing one here.

[juncai, 2016/08/23 00:30:40]

Acknowledged.

+                   row:(NSInteger)rowIndex {
+  return [chooserContentView_ createTableRowView:rowIndex];
 }
 
 - (BOOL)tableView:(NSTableView*)aTableView
@@ -57,6 +57,10 @@ initWithChooserDialogCocoa:(ChooserDialogCocoa*)chooserDialogCocoa
   return NO;
 }
 
+- (CGFloat)tableView:(NSTableView*)tableView heightOfRow:(NSInteger)row {
+  return [chooserContentView_ tableRowViewHeight:row];
+}
+
 - (void)tableViewSelectionDidChange:(NSNotification*)aNotification {
   [connectButton_ setEnabled:[tableView_ numberOfSelectedRows] > 0];
 }