Add signal strength indicator icon to WebBluetooth chooser on Mac

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
 
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/chooser_controller/chooser_controller.h"
 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"
@@ skipping 27 matching lines @@
   self.view = chooserContentView_;
   [chooserContentView_ updateTableView];
 
   return self;
 }
 
 - (NSInteger)numberOfRowsInTableView:(NSTableView*)tableView {
   return [chooserContentView_ numberOfOptions];
 }
 
-- (id)tableView:(NSTableView*)tableView
-    objectValueForTableColumn:(NSTableColumn*)tableColumn
-                          row:(NSInteger)rowIndex {
-  return [chooserContentView_ optionAtIndex:rowIndex];
+- (NSView*)tableView:(NSTableView*)tableView
+    viewForTableColumn:(NSTableColumn*)tableColumn

[Jeffrey Yasskin, 2016/08/19 18:30:05]

Another dumb question: why does this take a tableView and tableColumn that it
doesn't use?

[juncai, 2016/08/22 19:18:20]

https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/TableV...

https://developer.apple.com/library/mac/documentation/Cocoa/Reference/NSTable...:

I guess it is like a virtual function that user needs to implement to customize
the table view, and the virtual function's signature is fixed.

[Jeffrey Yasskin, 2016/08/22 21:59:24]

Yep, that's it. I missed that it was implementing a protocol. It'd be nice if
Chrome had a convention for documenting the protocols a class is implementing,
but if we don't, it's not worth inventing one here.

[juncai, 2016/08/23 00:30:40]

Acknowledged.

+                   row:(NSInteger)rowIndex {
+  return [chooserContentView_ createTableRowView:rowIndex];
 }
 
 - (BOOL)tableView:(NSTableView*)aTableView
     shouldEditTableColumn:(NSTableColumn*)aTableColumn
                       row:(NSInteger)rowIndex {
   return NO;
 }
 
+- (CGFloat)tableView:(NSTableView*)tableView heightOfRow:(NSInteger)row {
+  return [chooserContentView_ tableRowViewHeight:row];
+}
+
 - (void)tableViewSelectionDidChange:(NSNotification*)aNotification {
   [connectButton_ setEnabled:[tableView_ numberOfSelectedRows] > 0];
 }
 
 - (void)onConnect:(id)sender {
   [chooserContentView_ accept];
   chooserDialogCocoa_->Dismissed();
 }
 
 - (void)onCancel:(id)sender {
   [chooserContentView_ cancel];
   chooserDialogCocoa_->Dismissed();
 }
 
 - (ChooserContentViewCocoa*)chooserContentView {
   return chooserContentView_.get();
 }
 
 @end