Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2257723002: MD WebUI: Uglify vulcanized javascript bundles to remove comments/whitespace (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, calamity
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: Uglify vulcanized javascript bundles to remove comments/whitespace We run uglify in 'beautify' mode so that output is still human-readable, but comments and whitespace are removed. This reduces the size of resources.pak by 330K. BUG=629406, 638624 NOPRESUBMIT=true # crisper.js CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ce13eef039ce8ac44ae999ce62fd1bc3e0f0d069 Cr-Commit-Position: refs/heads/master@{#413070}

Patch Set 1 #

Patch Set 2 : Revulcanize #

Patch Set 3 : Reparent and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9751 lines, -21628 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 1 2 48 chunks +4154 lines, -9329 lines 0 comments Download
M chrome/browser/resources/md_history/app.crisper.js View 1 2 51 chunks +5587 lines, -12297 lines 0 comments Download
M chrome/browser/resources/vulcanize.py View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M docs/vulcanize.md View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (19 generated)
tsergeant
4 years, 4 months ago (2016-08-18 23:51:02 UTC) #7
Dan Beam
lgtm
4 years, 4 months ago (2016-08-19 01:40:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257723002/20001
4 years, 4 months ago (2016-08-19 06:38:52 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:20001)
4 years, 4 months ago (2016-08-19 06:39:59 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 06:41:11 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce13eef039ce8ac44ae999ce62fd1bc3e0f0d069
Cr-Commit-Position: refs/heads/master@{#413070}

Powered by Google App Engine
This is Rietveld 408576698