MD History: Synced Tabs fixes

MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47
Cr-Commit-Position: refs/heads/master@{#413061}

[tsergeant, 2016-08-18 02:59:21]

Description was changed from

==========
Synced Tabs fixes:

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
==========

to

==========
Synced Tabs fixes:

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-18 03:17:41]

Description was changed from

==========
Synced Tabs fixes:

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Synced Tabs fixes:

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-18 03:18:09]

Description was changed from

==========
MD History: Synced Tabs fixes:

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-18 03:18:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 03:18:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 04:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 04:03:41]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-08-19 00:15:25]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2016-08-19 04:02:38]

lgtm

https://codereview.chromium.org/2251323002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2251323002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:221: if
(updateCount == this.syncedDevices_.length) {
nit: sessionList.length >= this.syncedDevices_.length makes it clearer what's
going on.

[tsergeant, 2016-08-19 04:48:30]

https://codereview.chromium.org/2251323002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_history/synced_device_manager.js (right):

https://codereview.chromium.org/2251323002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_history/synced_device_manager.js:221: if
(updateCount == this.syncedDevices_.length) {
On 2016/08/19 04:02:37, calamity wrote:
> nit: sessionList.length >= this.syncedDevices_.length makes it clearer what's
> going on.

Good point, done.

[tsergeant, 2016-08-19 04:48:52]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-08-19 04:48:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2251323002/#ps40001
(title: "Review comment, revulcanize")

[commit-bot: I haz the power, 2016-08-19 04:49:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 06:03:33]

Description was changed from

==========
MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-19 06:03:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-19 06:05:45]

Description was changed from

==========
MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Synced Tabs fixes

* Correctly update device list when an item is deleted
* Make collapsed state a property of the model rather than element,
  fixing issues when the list shrinks or reorders.
* Tweak margin for long titles
* Close menu on scroll

BUG=635753
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47
Cr-Commit-Position: refs/heads/master@{#413061}
==========

[commit-bot: I haz the power, 2016-08-19 06:05:46]

Patchset 3 (id:??) landed as
https://crrev.com/dc837d2aabc3019ccb20858e9c842270b9d68e47
Cr-Commit-Position: refs/heads/master@{#413061}