Issue 2257703002: MD History: Improve test helpers, update synced tabs tests to use them

tsergeant

Description was changed from ========== MD History: Improve test helpers, update synced tabs tests to ...

4 years, 4 months ago (2016-08-18 01:31:20 UTC) #1

tsergeant

Description was changed from ========== MD History: Improve test helpers, update synced tabs tests to ...

4 years, 4 months ago (2016-08-18 01:37:12 UTC) #2

tsergeant

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

4 years, 4 months ago (2016-08-18 01:37:34 UTC) #3

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257703002/20001

4 years, 4 months ago (2016-08-18 01:38:04 UTC) #4

tsergeant

tsergeant@chromium.org changed reviewers: + calamity@chromium.org

4 years, 4 months ago (2016-08-18 01:38:15 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-18 03:38:56 UTC) #7

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

4 years, 4 months ago (2016-08-18 03:38:57 UTC) #8

calamity

lgtm. FYI, https://codereview.chromium.org/2248223003/ contains the same getSelectedList() change.

4 years, 4 months ago (2016-08-18 07:55:57 UTC) #9

tsergeant

The patchset sent to the CQ was uploaded after l-g-t-m from calamity@chromium.org Link to the ...

4 years, 4 months ago (2016-08-19 00:00:48 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257703002/60001

4 years, 4 months ago (2016-08-19 00:01:25 UTC) #12

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 4 months ago (2016-08-19 01:22:12 UTC) #13

commit-bot: I haz the power

Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/264535)

4 years, 4 months ago (2016-08-19 01:22:13 UTC) #14

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257703002/60001

4 years, 4 months ago (2016-08-19 01:30:06 UTC) #16

commit-bot: I haz the power

Description was changed from ========== MD History: Improve test helpers, update synced tabs tests to ...

4 years, 4 months ago (2016-08-19 02:38:48 UTC) #18

Message was sent while issue was closed.

Description was changed from

==========
MD History: Improve test helpers, update synced tabs tests to use them

Many of our existing tests rely heavily on the state of the whole page.
While this is necessary in many cases, we should avoid it when possible
and take steps to ensure the page state is properly reset between tests.

This CL adds new test helpers to support completely resetting the page
for each individual test. As part of this, CSS mixin/variable
definitions are moved so that they apply once to <html> rather than to
many different elements.

Finally, the test suite for <history-synced-device-manager> is updated
to use the new helpers. Most tests now directly test the manager
element, with no <history-app> integration. A separate test suite for
integration tests with a <history-app> is also available.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Improve test helpers, update synced tabs tests to use them

Many of our existing tests rely heavily on the state of the whole page.
While this is necessary in many cases, we should avoid it when possible
and take steps to ensure the page state is properly reset between tests.

This CL adds new test helpers to support completely resetting the page
for each individual test. As part of this, CSS mixin/variable
definitions are moved so that they apply once to <html> rather than to
many different elements.

Finally, the test suite for <history-synced-device-manager> is updated
to use the new helpers. Most tests now directly test the manager
element, with no <history-app> integration. A separate test suite for
integration tests with a <history-app> is also available.

BUG=425625
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/26684461f0a2babf696a9118d34c08d697699115
Cr-Commit-Position: refs/heads/master@{#413033}
==========

commit-bot: I haz the power

4 years, 4 months ago (2016-08-19 02:38:49 UTC) #19

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/26684461f0a2babf696a9118d34c08d697699115
Cr-Commit-Position: refs/heads/master@{#413033}

Issue 2257703002: MD History: Improve test helpers, update synced tabs tests to use them (Closed)

Description

Patch Set 1 #

Patch Set 2 : revulcanize #

Patch Set 3 : Rebase #

Patch Set 4 : Revulcanize #

Messages