chrome/browser/resources/md_history/history.js - Issue 2257703002: MD History: Improve test helpers, update synced tabs tests to use them

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history.js

Issue 2257703002: MD History: Improve test helpers, update synced tabs tests to use them (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revulcanize Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | chrome/browser/resources/md_history/shared_style.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history.js

diff --git a/chrome/browser/resources/md_history/history.js b/chrome/browser/resources/md_history/history.js

index 4cce580cc9e8ccc0e21f3930cb76b28bed560a43..8ac64280ae8ea74fce899e71b5f65b09c0672107 100644

--- a/chrome/browser/resources/md_history/history.js

+++ b/chrome/browser/resources/md_history/history.js

@@ -103,7 +103,9 @@ function historyDeleted() {

function updateSignInState(isUserSignedIn) {

waitForAppUpgrade().then(function() {

- /** @type {HistoryAppElement} */($('history-app'))

- .updateSignInState(isUserSignedIn);

+ if ($('history-app')) {

+ /** @type {HistoryAppElement} */($('history-app'))

+ .updateSignInState(isUserSignedIn);

+ }

});

}

« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | chrome/browser/resources/md_history/shared_style.html » ('j') | no next file with comments »