Handle early ServiceRequest errors in shell::ServiceContext

Handle early ServiceRequest errors in shell::ServiceContext

Sets an error handler immediately when binding ServiceContext's
ServiceRequest. This means Service::OnStop() may be invoked
without first receiving Service::OnStart().

Docs updated accordingly, and MojoShellConnectionImpl changed to
destroy its ConnectionFilter instances in OnStop().

This eliminates a race condition where a child process might not
detect an IPC Channel error in case of early browser process
exit.

BUG=623396
Committed: https://crrev.com/bd8ac0b42ea508a8768d3453431dbfbbe5c4dab0
Cr-Commit-Position: refs/heads/master@{#413002}

[Ken Rockot(use gerrit already), 2016-08-18 21:10:35]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 21:11:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-18 21:11:27]

rockot@chromium.org changed reviewers:
+ ben@chromium.org

[Ben Goodger (Google), 2016-08-18 21:27:04]

lgtm

[Ken Rockot(use gerrit already), 2016-08-18 21:46:25]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-18 21:46:33]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:47:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-18 23:28:12]

The CQ bit was unchecked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-18 23:28:18]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-18 23:28:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/2257693003/#ps20001
(title: ".")

[commit-bot: I haz the power, 2016-08-18 23:28:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-18 23:31:49]

Description was changed from

==========
Handle early ServiceRequest errors in shell::ServiceContext

Sets an error handler immediately when binding ServiceContext's
ServiceRequest. This means Service::OnStop() may be invoked
without first receiving Service::OnStart().

Docs updated accordingly, and MojoShellConnectionImpl changed to
shut itself down in OnStop(), primarily to ensure that all
ConnectionFilter instances are cleaned up at that time.

This eliminates a race condition where

BUG=623396
==========

to

==========
Handle early ServiceRequest errors in shell::ServiceContext

Sets an error handler immediately when binding ServiceContext's
ServiceRequest. This means Service::OnStop() may be invoked
without first receiving Service::OnStart().

Docs updated accordingly, and MojoShellConnectionImpl changed to
destroy its ConnectionFilter instances in OnStop().

This eliminates a race condition where a child process might not
detect an IPC Channel error in case of early browser process
exit.

BUG=623396
==========

[commit-bot: I haz the power, 2016-08-19 01:27:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 01:32:16]

Description was changed from

==========
Handle early ServiceRequest errors in shell::ServiceContext

Sets an error handler immediately when binding ServiceContext's
ServiceRequest. This means Service::OnStop() may be invoked
without first receiving Service::OnStart().

Docs updated accordingly, and MojoShellConnectionImpl changed to
destroy its ConnectionFilter instances in OnStop().

This eliminates a race condition where a child process might not
detect an IPC Channel error in case of early browser process
exit.

BUG=623396
==========

to

==========
Handle early ServiceRequest errors in shell::ServiceContext

Sets an error handler immediately when binding ServiceContext's
ServiceRequest. This means Service::OnStop() may be invoked
without first receiving Service::OnStart().

Docs updated accordingly, and MojoShellConnectionImpl changed to
destroy its ConnectionFilter instances in OnStop().

This eliminates a race condition where a child process might not
detect an IPC Channel error in case of early browser process
exit.

BUG=623396

Committed: https://crrev.com/bd8ac0b42ea508a8768d3453431dbfbbe5c4dab0
Cr-Commit-Position: refs/heads/master@{#413002}
==========

[commit-bot: I haz the power, 2016-08-19 01:32:17]

Patchset 2 (id:??) landed as
https://crrev.com/bd8ac0b42ea508a8768d3453431dbfbbe5c4dab0
Cr-Commit-Position: refs/heads/master@{#413002}