Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2257203002: make LayerIter private, and remove skipClip option (Closed)

Created:
4 years, 4 months ago by reed1
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

make LayerIter private, and remove skipClip option BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257203002 Committed: https://skia.googlesource.com/skia/+/3aafe111b6cc388400092851cc53bbbdfcb8a81c

Patch Set 1 #

Patch Set 2 : remove related dead code #

Total comments: 2

Patch Set 3 : remove dead comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -210 lines) Patch
M include/core/SkCanvas.h View 3 chunks +38 lines, -39 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 5 chunks +13 lines, -18 lines 0 comments Download
M src/utils/SkCanvasStateUtils.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/CanvasTest.cpp View 6 chunks +3 lines, -152 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
reed1
4 years, 4 months ago (2016-08-18 18:09:17 UTC) #3
f(malita)
LGTM https://codereview.chromium.org/2257203002/diff/20001/src/utils/SkCanvasStateUtils.cpp File src/utils/SkCanvasStateUtils.cpp (right): https://codereview.chromium.org/2257203002/diff/20001/src/utils/SkCanvasStateUtils.cpp#newcode225 src/utils/SkCanvasStateUtils.cpp:225: for (SkCanvas::LayerIter layer(canvas/*, true skipEmptyClips*/); !layer.done(); layer.next()) { ...
4 years, 4 months ago (2016-08-18 18:29:31 UTC) #6
reed1
https://codereview.chromium.org/2257203002/diff/20001/src/utils/SkCanvasStateUtils.cpp File src/utils/SkCanvasStateUtils.cpp (right): https://codereview.chromium.org/2257203002/diff/20001/src/utils/SkCanvasStateUtils.cpp#newcode225 src/utils/SkCanvasStateUtils.cpp:225: for (SkCanvas::LayerIter layer(canvas/*, true skipEmptyClips*/); !layer.done(); layer.next()) { On ...
4 years, 4 months ago (2016-08-18 19:18:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2257203002/40001
4 years, 4 months ago (2016-08-18 19:18:30 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 19:45:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/3aafe111b6cc388400092851cc53bbbdfcb8a81c

Powered by Google App Engine
This is Rietveld 408576698