Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2599)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index 9ab61ab6c9a7884c30f7418d155fc767a2b94716..4f8c912849605a6a329ea4c3f154ef9c675e2531 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -5981,7 +5981,7 @@ TEST_F(ExtensionServiceTest, ConcurrentExternalLocalFile) {
// An external provider starts installing from a local crx.
std::unique_ptr<ExternalInstallInfoFile> info(new ExternalInstallInfoFile(
- kGoodId, base::WrapUnique(new Version(kVersion123)), kInvalidPathToCrx,
+ kGoodId, base::MakeUnique<Version>(kVersion123), kInvalidPathToCrx,
Manifest::EXTERNAL_PREF, kCreationFlags, kDontMarkAcknowledged,
kDontInstallImmediately));
EXPECT_TRUE(service()->OnExternalExtensionFileFound(*info));
@@ -6017,7 +6017,7 @@ TEST_F(ExtensionServiceTest, ConcurrentExternalLocalFile) {
GURL kUpdateUrl("http://example.com/update");
std::unique_ptr<ExternalInstallInfoUpdateUrl> update_info(
new ExternalInstallInfoUpdateUrl(
- kGoodId, std::string(), base::WrapUnique(new GURL(kUpdateUrl)),
+ kGoodId, std::string(), base::MakeUnique<GURL>(kUpdateUrl),
Manifest::EXTERNAL_POLICY_DOWNLOAD, Extension::NO_FLAGS, false));
EXPECT_TRUE(service()->OnExternalExtensionUpdateUrlFound(*update_info, true));
EXPECT_TRUE((pending_info = pending->GetById(kGoodId)));

Powered by Google App Engine
This is Rietveld 408576698