chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc - Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

Issue 2257113002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/windows_event_router.cc ('K') | « chrome/browser/extensions/api/web_request/web_request_api_unittest.cc ('k') | chrome/browser/extensions/chrome_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

index 6e3c151a3763327439548299a1ebfcf52680fc4e..6a01367460b2b2b07d93c8eb15518d379af2829f 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc

@@ -98,7 +98,7 @@ void WebrtcAudioPrivateEventService::SignalEvent() {

extension->permissions_data()->HasAPIPermission("webrtcAudioPrivate")) {

std::unique_ptr<Event> event(

new Event(events::WEBRTC_AUDIO_PRIVATE_ON_SINKS_CHANGED, kEventName,

Devlin 2016/08/29 15:10:01 MakeUnique

Adam Rice 2016/08/30 07:03:00 Done.

- base::WrapUnique(new base::ListValue())));

+ base::MakeUnique<base::ListValue>()));

router->DispatchEventToExtension(extension_id, std::move(event));

}