|
|
DescriptionFix uninitialized var in DirectRenderer
|visible_| was not initialized, leading to test flakes. Initializing
to false.
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
Committed: https://crrev.com/4ac985eade120070545fd8f00abc91f495aa246d
Cr-Commit-Position: refs/heads/master@{#412706}
Patch Set 1 #Patch Set 2 : rebase #
Total comments: 1
Patch Set 3 : move init to header #Messages
Total messages: 18 (10 generated)
Description was changed from ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org ========== to ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
https://codereview.chromium.org/2256903002/diff/20001/cc/output/direct_render... File cc/output/direct_renderer.cc (right): https://codereview.chromium.org/2256903002/diff/20001/cc/output/direct_render... cc/output/direct_renderer.cc:76: visible_(false) {} Can you just do it in the header file but LGTM
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/2256903002/#ps40001 (title: "move init to header")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ericrk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel ========== to ========== Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/4ac985eade120070545fd8f00abc91f495aa246d Cr-Commit-Position: refs/heads/master@{#412706} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4ac985eade120070545fd8f00abc91f495aa246d Cr-Commit-Position: refs/heads/master@{#412706} |