Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2256903002: Fix uninitialized var in DirectRenderer (Closed)

Created:
4 years, 4 months ago by ericrk
Modified:
4 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org, megjablon
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix uninitialized var in DirectRenderer |visible_| was not initialized, leading to test flakes. Initializing to false. TBR=danakj@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/4ac985eade120070545fd8f00abc91f495aa246d Cr-Commit-Position: refs/heads/master@{#412706}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1

Patch Set 3 : move init to header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/output/direct_renderer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256903002/1
4 years, 4 months ago (2016-08-17 21:58:45 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/209362) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 4 months ago (2016-08-17 22:02:05 UTC) #5
danakj
https://codereview.chromium.org/2256903002/diff/20001/cc/output/direct_renderer.cc File cc/output/direct_renderer.cc (right): https://codereview.chromium.org/2256903002/diff/20001/cc/output/direct_renderer.cc#newcode76 cc/output/direct_renderer.cc:76: visible_(false) {} Can you just do it in the ...
4 years, 4 months ago (2016-08-17 22:08:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256903002/40001
4 years, 4 months ago (2016-08-17 22:17:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/220230)
4 years, 4 months ago (2016-08-17 22:57:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256903002/40001
4 years, 4 months ago (2016-08-17 23:50:34 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-18 00:34:44 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 00:36:53 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ac985eade120070545fd8f00abc91f495aa246d
Cr-Commit-Position: refs/heads/master@{#412706}

Powered by Google App Engine
This is Rietveld 408576698