Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: cc/output/direct_renderer.cc

Issue 2256903002: Fix uninitialized var in DirectRenderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/direct_renderer.h" 5 #include "cc/output/direct_renderer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <unordered_map> 9 #include <unordered_map>
10 #include <utility> 10 #include <utility>
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 DirectRenderer::DrawingFrame::DrawingFrame() = default; 66 DirectRenderer::DrawingFrame::DrawingFrame() = default;
67 DirectRenderer::DrawingFrame::~DrawingFrame() = default; 67 DirectRenderer::DrawingFrame::~DrawingFrame() = default;
68 68
69 DirectRenderer::DirectRenderer(const RendererSettings* settings, 69 DirectRenderer::DirectRenderer(const RendererSettings* settings,
70 OutputSurface* output_surface, 70 OutputSurface* output_surface,
71 ResourceProvider* resource_provider) 71 ResourceProvider* resource_provider)
72 : settings_(settings), 72 : settings_(settings),
73 output_surface_(output_surface), 73 output_surface_(output_surface),
74 resource_provider_(resource_provider), 74 resource_provider_(resource_provider),
75 overlay_processor_(new OverlayProcessor(output_surface)) {} 75 overlay_processor_(new OverlayProcessor(output_surface)),
76 visible_(false) {}
danakj 2016/08/17 22:08:37 Can you just do it in the header file but LGTM
76 77
77 DirectRenderer::~DirectRenderer() = default; 78 DirectRenderer::~DirectRenderer() = default;
78 79
79 void DirectRenderer::Initialize() { 80 void DirectRenderer::Initialize() {
80 overlay_processor_->Initialize(); 81 overlay_processor_->Initialize();
81 82
82 auto* context_provider = output_surface_->context_provider(); 83 auto* context_provider = output_surface_->context_provider();
83 84
84 use_partial_swap_ = settings_->partial_swap_enabled && CanPartialSwap(); 85 use_partial_swap_ = settings_->partial_swap_enabled && CanPartialSwap();
85 allow_empty_swap_ = use_partial_swap_; 86 allow_empty_swap_ = use_partial_swap_;
(...skipping 499 matching lines...) Expand 10 before | Expand all | Expand 10 after
585 auto iter = render_pass_textures_.find(id); 586 auto iter = render_pass_textures_.find(id);
586 return iter != render_pass_textures_.end() && iter->second->id(); 587 return iter != render_pass_textures_.end() && iter->second->id();
587 } 588 }
588 589
589 // static 590 // static
590 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) { 591 gfx::Size DirectRenderer::RenderPassTextureSize(const RenderPass* render_pass) {
591 return render_pass->output_rect.size(); 592 return render_pass->output_rect.size();
592 } 593 }
593 594
594 } // namespace cc 595 } // namespace cc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698