|
|
Created:
4 years, 4 months ago by calamity Modified:
4 years, 4 months ago CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@more_stats Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix MD History PRESUBMIT.
This CL adds vulcanize and crisper generated files to the PRESUBMIT
exclusion and fixes an issue where the MD History PRESUBMIT script would
always fail after vulcanize.py was run.
BUG=629406
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/8ec9430cce290817d358bf8fed2ff7015b63cb4f
Cr-Commit-Position: refs/heads/master@{#413658}
Patch Set 1 #Patch Set 2 : de-dependent #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== Fix MD History PRESUBMIT. This CL adds vulcanize and crisper generated files to the PRESUBMIT exclusion and fixes an issue where the MD History PRESUBMIT script would always fail after vulcanize.py was run. BUG=629406 ========== to ========== Fix MD History PRESUBMIT. This CL adds vulcanize and crisper generated files to the PRESUBMIT exclusion and fixes an issue where the MD History PRESUBMIT script would always fail after vulcanize.py was run. BUG=629406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
calamity@chromium.org changed reviewers: + tsergeant@chromium.org
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
lgtm probably gonna duplicate this for downloads soon, though ;)
calamity@chromium.org changed reviewers: + dpranke@chromium.org
+dpranke for PRESUBMIT.py
lgtm
The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2256873004/#ps20001 (title: "rebase")
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2255033002 Patch 80001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org, dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2256873004/#ps40001 (title: "de-dependent")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fix MD History PRESUBMIT. This CL adds vulcanize and crisper generated files to the PRESUBMIT exclusion and fixes an issue where the MD History PRESUBMIT script would always fail after vulcanize.py was run. BUG=629406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix MD History PRESUBMIT. This CL adds vulcanize and crisper generated files to the PRESUBMIT exclusion and fixes an issue where the MD History PRESUBMIT script would always fail after vulcanize.py was run. BUG=629406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8ec9430cce290817d358bf8fed2ff7015b63cb4f Cr-Commit-Position: refs/heads/master@{#413658} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8ec9430cce290817d358bf8fed2ff7015b63cb4f Cr-Commit-Position: refs/heads/master@{#413658} |