Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2256873004: Fix MD History PRESUBMIT. (Closed)

Created:
4 years, 4 months ago by calamity
Modified:
4 years, 4 months ago
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@more_stats
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MD History PRESUBMIT. This CL adds vulcanize and crisper generated files to the PRESUBMIT exclusion and fixes an issue where the MD History PRESUBMIT script would always fail after vulcanize.py was run. BUG=629406 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8ec9430cce290817d358bf8fed2ff7015b63cb4f Cr-Commit-Position: refs/heads/master@{#413658}

Patch Set 1 #

Patch Set 2 : de-dependent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_history/PRESUBMIT.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
calamity
4 years, 4 months ago (2016-08-19 14:25:53 UTC) #3
Dan Beam
lgtm probably gonna duplicate this for downloads soon, though ;)
4 years, 4 months ago (2016-08-19 17:40:59 UTC) #5
calamity
+dpranke for PRESUBMIT.py
4 years, 4 months ago (2016-08-22 03:34:03 UTC) #7
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-22 17:35:57 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2255033002 Patch 80001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-23 03:04:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256873004/40001
4 years, 4 months ago (2016-08-23 03:05:36 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-23 03:57:06 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 03:59:24 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ec9430cce290817d358bf8fed2ff7015b63cb4f
Cr-Commit-Position: refs/heads/master@{#413658}

Powered by Google App Engine
This is Rietveld 408576698