Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/resources/md_history/PRESUBMIT.py

Issue 2256873004: Fix MD History PRESUBMIT. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@more_stats
Patch Set: de-dependent Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os.path 5 import os.path
6 import time 6 import time
7 7
8 def CheckChangeOnUpload(input_api, output_api): 8 def CheckChangeOnUpload(input_api, output_api):
9 """Warn when changing md_history without vulcanizing.""" 9 """Warn when changing md_history without vulcanizing."""
10 10
11 def _is_md_history_file(path): 11 def _is_md_history_file(path):
12 return (path.startswith('chrome/browser/resources/md_history') and 12 return (path.startswith('chrome/browser/resources/md_history') and
13 (not path.endswith('externs.js')) and 13 (not path.endswith('externs.js')) and
14 (not path.endswith('app.crisper.js')) and
15 (not path.endswith('app.vulcanized.html')) and
14 (path.endswith('js') or path.endswith('html'))) 16 (path.endswith('js') or path.endswith('html')))
15 17
16 def _affects_file(filename, paths): 18 def _affects_file(filename, paths):
17 return any([filename in path for path in paths]) 19 return any([filename in path for path in paths])
18 20
19 paths = [x.LocalPath() for x in input_api.change.AffectedFiles()] 21 paths = [x.LocalPath() for x in input_api.change.AffectedFiles()]
20 earliest_vulcanize_change = min(os.path.getmtime(x) for x in 22 earliest_vulcanize_change = min(os.path.getmtime(x) for x in
21 ['app.vulcanized.html', 'app.crisper.js']) 23 ['app.vulcanized.html', 'app.crisper.js'])
22 history_changes = filter(_is_md_history_file, paths) 24 history_changes = filter(_is_md_history_file, paths)
23 latest_history_change = 0 25 latest_history_change = 0
24 if history_changes: 26 if history_changes:
25 latest_history_change = max(os.path.getmtime(os.path.split(x)[1]) for x in 27 latest_history_change = max(os.path.getmtime(os.path.split(x)[1]) for x in
26 history_changes) 28 history_changes)
27 29
28 if latest_history_change > earliest_vulcanize_change: 30 if latest_history_change > earliest_vulcanize_change:
29 return [output_api.PresubmitPromptWarning( 31 return [output_api.PresubmitPromptWarning(
30 'Vulcanize must be run when changing files in md_history. See ' 32 'Vulcanize must be run when changing files in md_history. See '
31 'docs/vulcanize.md.')] 33 'docs/vulcanize.md.')]
32 return [] 34 return []
OLDNEW
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698