Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: src/gpu/vk/GrVkFramebuffer.cpp

Issue 2256843002: Don't add the resolve attachment to vulkan render passes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/vk/GrVkFramebuffer.h ('k') | src/gpu/vk/GrVkGpu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/vk/GrVkFramebuffer.cpp
diff --git a/src/gpu/vk/GrVkFramebuffer.cpp b/src/gpu/vk/GrVkFramebuffer.cpp
index 49c6e414fc110e4d1e5fc5724976d95d749656b6..f9add633ce8ade5fef24c001b5d1acb709d83806 100644
--- a/src/gpu/vk/GrVkFramebuffer.cpp
+++ b/src/gpu/vk/GrVkFramebuffer.cpp
@@ -15,7 +15,6 @@ GrVkFramebuffer* GrVkFramebuffer::Create(GrVkGpu* gpu,
int width, int height,
const GrVkRenderPass* renderPass,
const GrVkImageView* colorAttachment,
- const GrVkImageView* resolveAttachment,
const GrVkImageView* stencilAttachment) {
// At the very least we need a renderPass and a colorAttachment
SkASSERT(renderPass);
@@ -24,9 +23,6 @@ GrVkFramebuffer* GrVkFramebuffer::Create(GrVkGpu* gpu,
VkImageView attachments[3];
attachments[0] = colorAttachment->imageView();
int numAttachments = 1;
- if (resolveAttachment) {
- attachments[numAttachments++] = resolveAttachment->imageView();
- }
if (stencilAttachment) {
attachments[numAttachments++] = stencilAttachment->imageView();
}
« no previous file with comments | « src/gpu/vk/GrVkFramebuffer.h ('k') | src/gpu/vk/GrVkGpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698