Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2256773003: [Downloads] Better handle opening files (Closed)

Created:
4 years, 4 months ago by gone
Modified:
4 years, 4 months ago
Reviewers:
Theresa
CC:
chromium-reviews, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Downloads] Better handle opening files * Don't always throw up an Intent picker when a user asks to open a file. * Don't even try to open deleted files. BUG=616324 Committed: https://crrev.com/ab114817ff29ba33f30607b6d5b0ae88c892c644 Cr-Commit-Position: refs/heads/master@{#412714}

Patch Set 1 #

Patch Set 2 : Don't open deleted files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java View 1 4 chunks +10 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
gone
4 years, 4 months ago (2016-08-17 23:55:35 UTC) #2
Theresa
lgtm
4 years, 4 months ago (2016-08-18 00:05:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256773003/20001
4 years, 4 months ago (2016-08-18 00:07:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 01:18:22 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 01:21:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab114817ff29ba33f30607b6d5b0ae88c892c644
Cr-Commit-Position: refs/heads/master@{#412714}

Powered by Google App Engine
This is Rietveld 408576698