[Downloads] Add basic DownloadHistoryAdapterTests

[Downloads] Add basic DownloadHistoryAdapterTests

* Stub out calls from the DownloadHistoryAdapter to the
  backends.

* Add a DownloadHistoryAdapterTest that tests basic things
  about how the Adapter is expected to work, including
  initialization, dealing with Incognito tabs, alerts
  about new downloads, and alerts about removed downloads.

BUG=616324
Committed: https://crrev.com/0ffc833adb786bc60f713d8f8e158fdc9500058f
Cr-Commit-Position: refs/heads/master@{#412990}

[gone, 2016-08-16 07:38:36]

dfalcantara@chromium.org changed reviewers:
+ ianwen@chromium.org

[gone, 2016-08-17 23:18:58]

The CQ bit was checked by dfalcantara@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 23:19:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-18 16:38:50]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org
- ianwen@chromium.org

[gone, 2016-08-18 16:38:50]

Swapping over.

[Theresa, 2016-08-18 17:25:42]

lgtm

https://chromiumcodereview.appspot.com/2247923003/diff/80001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java
(right):

https://chromiumcodereview.appspot.com/2247923003/diff/80001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java:165:
public void testInitialize_OffTheRecord_TwoItemsOneBucket() throws Exception {
nit: naming again, maybe OneBucketTwoItems?

[gone, 2016-08-18 17:52:23]

https://chromiumcodereview.appspot.com/2247923003/diff/80001/chrome/android/j...
File
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java
(right):

https://chromiumcodereview.appspot.com/2247923003/diff/80001/chrome/android/j...
chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java:165:
public void testInitialize_OffTheRecord_TwoItemsOneBucket() throws Exception {
On 2016/08/18 17:25:42, Theresa Wellington wrote:
> nit: naming again, maybe OneBucketTwoItems?

I'm good at naming things... Went with "Date" instead.

[gone, 2016-08-18 17:52:27]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-18 17:52:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/2247923003/#ps100001 (title: "Comments")

[commit-bot: I haz the power, 2016-08-18 17:52:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 20:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:15:46]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[gone, 2016-08-18 20:19:46]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-18 20:20:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-18 21:29:01]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-08-18 21:29:02]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-18 21:29:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2016-08-18 22:05:48]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-18 22:05:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/2247923003/#ps120001 (title: "Rebase
again")

[commit-bot: I haz the power, 2016-08-18 22:07:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 23:22:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 23:22:29]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[gone, 2016-08-18 23:22:45]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2016-08-18 23:23:15]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2016-08-18 23:23:16]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2016-08-18 23:23:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:31:19]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-19 00:39:58]

Description was changed from

==========
[Downloads] Add basic DownloadHistoryAdapterTests

* Stub out calls from the DownloadHistoryAdapter to the
  backends.

* Add a DownloadHistoryAdapterTest that tests basic things
  about how the Adapter is expected to work, including
  initialization, dealing with Incognito tabs, alerts
  about new downloads, and alerts about removed downloads.

BUG=616324
==========

to

==========
[Downloads] Add basic DownloadHistoryAdapterTests

* Stub out calls from the DownloadHistoryAdapter to the
  backends.

* Add a DownloadHistoryAdapterTest that tests basic things
  about how the Adapter is expected to work, including
  initialization, dealing with Incognito tabs, alerts
  about new downloads, and alerts about removed downloads.

BUG=616324

Committed: https://crrev.com/0ffc833adb786bc60f713d8f8e158fdc9500058f
Cr-Commit-Position: refs/heads/master@{#412990}
==========

[commit-bot: I haz the power, 2016-08-19 00:39:59]

Patchset 7 (id:??) landed as
https://crrev.com/0ffc833adb786bc60f713d8f8e158fdc9500058f
Cr-Commit-Position: refs/heads/master@{#412990}