Re-write many calls to WrapUnique() with MakeUnique()

Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
Committed: https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57
Cr-Commit-Position: refs/heads/master@{#413404}

[Adam Rice, 2016-08-18 10:28:53]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 10:29:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 11:31:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 11:31:51]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-08-19 07:04:52]

ricea@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-08-19 16:50:07]

lgtm w/ tiny request

https://codereview.chromium.org/2256733004/diff/1/components/sync/device_info...
File components/sync/device_info/device_info_service.cc (right):

https://codereview.chromium.org/2256733004/diff/1/components/sync/device_info...
components/sync/device_info/device_info_service.cc:345:
std::unique_ptr<DeviceInfoSpecifics> specifics(
nit: while you're here, could you switch this to the "specifics =" form?

[Adam Rice, 2016-08-22 01:50:48]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-22 01:50:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2256733004/#ps20001
(title: "Change braced construction to assignment construction")

[commit-bot: I haz the power, 2016-08-22 01:51:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2016-08-22 01:51:15]

https://codereview.chromium.org/2256733004/diff/1/components/sync/device_info...
File components/sync/device_info/device_info_service.cc (right):

https://codereview.chromium.org/2256733004/diff/1/components/sync/device_info...
components/sync/device_info/device_info_service.cc:345:
std::unique_ptr<DeviceInfoSpecifics> specifics(
On 2016/08/19 16:50:07, maxbogue wrote:
> nit: while you're here, could you switch this to the "specifics =" form?

Done.

[commit-bot: I haz the power, 2016-08-22 01:53:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 01:53:42]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Adam Rice, 2016-08-22 02:24:11]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2016-08-22 02:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2256733004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-22 02:24:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 04:25:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-22 04:27:57]

Description was changed from

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812
==========

to

==========
Re-write many calls to WrapUnique() with MakeUnique()

A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Committed: https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57
Cr-Commit-Position: refs/heads/master@{#413404}
==========

[commit-bot: I haz the power, 2016-08-22 04:27:58]

Patchset 3 (id:??) landed as
https://crrev.com/08e66e6f17755de8d0082593183f7d67ce13cb57
Cr-Commit-Position: refs/heads/master@{#413404}