components/sync/core/shared_model_type_processor.cc - Issue 2256733004: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/core/shared_model_type_processor.cc

Issue 2256733004: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/core/processor_entity_tracker_unittest.cc ('k') | components/sync/core/shared_model_type_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/core/shared_model_type_processor.cc

diff --git a/components/sync/core/shared_model_type_processor.cc b/components/sync/core/shared_model_type_processor.cc

index 06125bbb1affc2872f724c3e38fb6363e5f1d90e..4995f1ed027d17d86f26fd995dc73a08e4bd3059 100644

--- a/components/sync/core/shared_model_type_processor.cc

+++ b/components/sync/core/shared_model_type_processor.cc

@@ -172,9 +172,10 @@ void SharedModelTypeProcessor::ConnectIfReady() {

if (!start_error_.IsSet()) {

activation_context = base::WrapUnique(new ActivationContext);

activation_context->data_type_state = data_type_state_;

- activation_context->type_processor = base::WrapUnique(

- new ModelTypeProcessorProxy(weak_ptr_factory_.GetWeakPtr(),

- base::ThreadTaskRunnerHandle::Get()));

+ activation_context->type_processor =

+ base::MakeUnique<ModelTypeProcessorProxy>(

+ weak_ptr_factory_.GetWeakPtr(),

+ base::ThreadTaskRunnerHandle::Get());

}

start_callback_.Run(start_error_, std::move(activation_context));