Add alternative spot shadow to Android shadow sample

Add alternative spot shadow to Android shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246273003

Committed: https://skia.googlesource.com/skia/+/d7315f91330614342195c30b6169c696ad9d12d3

[jvanverth1, 2016-08-17 15:25:57]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[robertphillips, 2016-08-17 15:44:40]

lgtm

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:150: !path.isRect(&pathRect)) {
this-> ?

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:160: 
stroke shape -> "coverage" RRect ?

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:172: SkPaint paint;
Can this be BW ? Does that give us any advantage ?

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:175: unsigned char gray = (unsigned
char)(ambientAlpha*umbraAlpha*255.999f);
// convert the radius to fixed point 8.8 & place it in the G,B components of the
color
?

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:268: !path.isRect(&pathRect)) {
this->

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:299: SkPaint paint;
same Q here

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:302: paint.setShader(gaussShader);
Maybe make_super_color(grey, radius) ?

[jvanverth1, 2016-08-17 16:19:28]

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
File samplecode/SampleAndroidShadows.cpp (right):

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:150: !path.isRect(&pathRect)) {
On 2016/08/17 15:44:40, robertphillips wrote:
> this-> ?

Done.

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:160: 
On 2016/08/17 15:44:39, robertphillips wrote:
> stroke shape -> "coverage" RRect ?

Done. And thanks -- there was a bug here.

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:172: SkPaint paint;
On 2016/08/17 15:44:40, robertphillips wrote:
> Can this be BW ? Does that give us any advantage ?

No, it can't. We need the anti-aliased rrect renderer.

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:175: unsigned char gray = (unsigned
char)(ambientAlpha*umbraAlpha*255.999f);
On 2016/08/17 15:44:39, robertphillips wrote:
> // convert the radius to fixed point 8.8 & place it in the G,B components of
the
> color
> ?

Done.

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:268: !path.isRect(&pathRect)) {
On 2016/08/17 15:44:39, robertphillips wrote:
> this->

Done.

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:299: SkPaint paint;
On 2016/08/17 15:44:40, robertphillips wrote:
> same Q here 

Same answer. :-)

https://codereview.chromium.org/2256713002/diff/1/samplecode/SampleAndroidSha...
samplecode/SampleAndroidShadows.cpp:302: paint.setShader(gaussShader);
On 2016/08/17 15:44:40, robertphillips wrote:
> Maybe make_super_color(grey, radius) ?

Good idea, I'll add something like that to SkGaussianEdgeShader in a later fix
(don't want to touch the header right now).

[jvanverth1, 2016-08-17 16:19:33]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-08-17 16:19:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2256713002/#ps20001
(title: "Address comments; fix scale")

[commit-bot: I haz the power, 2016-08-17 16:19:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 17:06:20]

Description was changed from

==========
Add alternative spot shadow to Android shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246273003
==========

to

==========
Add alternative spot shadow to Android shadow sample

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2246273003

Committed:
https://skia.googlesource.com/skia/+/d7315f91330614342195c30b6169c696ad9d12d3
==========

[commit-bot: I haz the power, 2016-08-17 17:06:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d7315f91330614342195c30b6169c696ad9d12d3