Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2256453002: Update test code to check what is displayed in chooser's table view (Closed)

Created:
4 years, 4 months ago by juncai
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek, msw
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update test code to check what is displayed in chooser's table view This CL added more test code to ChooserDialogCocoaControllerTest and ChooserContentViewTest to check what is displayed in chooser's table view. BUG=638350 Committed: https://crrev.com/e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c Cr-Commit-Position: refs/heads/master@{#412415}

Patch Set 1 : updated test code to check what is displayed in chooser's table view #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 1 18 chunks +40 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/chooser_content_view_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
juncai
msw@chromium.org: Please review changes in //chrome/browser/ui/views/chooser_content_view_unittest.cc rsesek@chromium.org: Please review changes in //chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
4 years, 4 months ago (2016-08-16 21:56:20 UTC) #6
Robert Sesek
https://codereview.chromium.org/2256453002/diff/1/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm (right): https://codereview.chromium.org/2256453002/diff/1/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm#newcode94 chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:94: EXPECT_EQ( How about: EXPECT_NSEQ(l10n_util::GetStringNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT), [[table_view_ preparedCellAtColumn:0 row:0] stringValue]); https://codereview.chromium.org/2256453002/diff/1/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm#newcode117 ...
4 years, 4 months ago (2016-08-16 22:30:17 UTC) #7
juncai
https://codereview.chromium.org/2256453002/diff/1/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm File chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm (right): https://codereview.chromium.org/2256453002/diff/1/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm#newcode94 chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm:94: EXPECT_EQ( On 2016/08/16 22:30:17, Robert Sesek wrote: > How ...
4 years, 4 months ago (2016-08-16 23:03:21 UTC) #10
Robert Sesek
lgtm
4 years, 4 months ago (2016-08-16 23:16:23 UTC) #11
msw
lgtm
4 years, 4 months ago (2016-08-17 01:11:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256453002/20001
4 years, 4 months ago (2016-08-17 01:34:13 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-17 01:38:32 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 01:40:44 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1bc6e5a4bcdca1ab5a242c504a3a65355ce970c
Cr-Commit-Position: refs/heads/master@{#412415}

Powered by Google App Engine
This is Rietveld 408576698