Update test code to check what is displayed in chooser's table view

chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 #include <vector>
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chooser_controller/mock_chooser_controller.h"
 #import "chrome/browser/ui/cocoa/chooser_content_view_cocoa.h"
 #import "chrome/browser/ui/cocoa/cocoa_profile_test.h"
 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
 #import "chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa.h"
 #include "chrome/browser/ui/cocoa/spinner_view.h"
+#include "chrome/grit/generated_resources.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "testing/gtest_mac.h"
+#include "ui/base/l10n/l10n_util.h"
 
 class ChooserDialogCocoaControllerTest : public CocoaProfileTest {
  protected:
   ChooserDialogCocoaControllerTest() {}
   ~ChooserDialogCocoaControllerTest() override {}
 
   void SetUp() override {
     CocoaProfileTest::SetUp();
     ASSERT_TRUE(browser());
   }
@@ skipping 49 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ChooserDialogCocoaControllerTest);
 };
 
 TEST_F(ChooserDialogCocoaControllerTest, InitialState) {
   CreateChooserDialog();
 
   // Since "No devices found." needs to be displayed on the |table_view_|,
   // the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
+  EXPECT_EQ(

[Robert Sesek, 2016/08/16 22:30:17]

How about:
 
EXPECT_NSEQ(l10n_util::GetStringNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
            [[table_view_ preparedCellAtColumn:0 row:0] stringValue]);

[juncai, 2016/08/16 23:03:21]

Done.

+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   // |table_view_| should be disabled since there is no option shown.
   ASSERT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   // |connect_button_| should be disabled since no option selected.
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
   ASSERT_TRUE(help_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, AddOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   // |table_view_| should be enabled since there is an option.
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("a"),

[Robert Sesek, 2016/08/16 22:30:17]

Similarly,

EXPECT_NSEQ(@"a", …);

[juncai, 2016/08/16 23:03:21]

Done.

+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
   ASSERT_TRUE(help_button_.enabled);
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   EXPECT_EQ(2, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("b"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
   EXPECT_EQ(3, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("c"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:2] stringValue]));
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, RemoveOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("b"));
   EXPECT_EQ(2, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("a"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
+  EXPECT_EQ(base::ASCIIToUTF16("c"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
 
   // Remove a non-existent option, the number of rows should not change.
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("non-existent"));
   EXPECT_EQ(2, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("a"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
+  EXPECT_EQ(base::ASCIIToUTF16("c"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("c"));
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("a"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("a"));
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   // |table_view_| should be disabled since all options are removed.
   ASSERT_FALSE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, UpdateOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   chooser_controller_->OptionUpdated(base::ASCIIToUTF16("b"),
                                      base::ASCIIToUTF16("d"));
 
   EXPECT_EQ(3, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
-
-  NSCell* cell = [table_view_ preparedCellAtColumn:0 row:1];
+  EXPECT_EQ(base::ASCIIToUTF16("a"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_EQ(base::ASCIIToUTF16("d"),
-            base::SysNSStringToUTF16([cell stringValue]));
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
+  EXPECT_EQ(base::ASCIIToUTF16("c"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:2] stringValue]));
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, AddAndRemoveOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   EXPECT_EQ(1, table_view_.numberOfRows);
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   EXPECT_EQ(2, table_view_.numberOfRows);
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("b"));
@@ skipping 17 matching lines @@
 
   chooser_controller_->OptionUpdated(base::ASCIIToUTF16("b"),
                                      base::ASCIIToUTF16("d"));
 
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("d"));
 
   EXPECT_EQ(2, table_view_.numberOfRows);
   EXPECT_EQ(1, table_view_.numberOfColumns);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(-1, table_view_.selectedRow);
-
-  NSCell* cell_a = [table_view_ preparedCellAtColumn:0 row:0];
   EXPECT_EQ(base::ASCIIToUTF16("a"),
-            base::SysNSStringToUTF16([cell_a stringValue]));
-
-  NSCell* cell_c = [table_view_ preparedCellAtColumn:0 row:1];
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_EQ(base::ASCIIToUTF16("c"),
-            base::SysNSStringToUTF16([cell_c stringValue]));
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, SelectAndDeselectAnOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0.
@@ skipping 108 matching lines @@
 
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
 
   // Update option 1.
   chooser_controller_->OptionUpdated(base::ASCIIToUTF16("b"),
                                      base::ASCIIToUTF16("d"));
 
   EXPECT_EQ(1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("a"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
+  EXPECT_EQ(base::ASCIIToUTF16("d"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:1] stringValue]));
+  EXPECT_EQ(base::ASCIIToUTF16("c"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:2] stringValue]));
   ASSERT_TRUE(connect_button_.enabled);
-
-  NSCell* cell = [table_view_ preparedCellAtColumn:0 row:1];
-  EXPECT_EQ(base::ASCIIToUTF16("d"),
-            base::SysNSStringToUTF16([cell stringValue]));
 }
 
 TEST_F(ChooserDialogCocoaControllerTest,
        AddAnOptionAndSelectItAndRemoveTheSelectedOption) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
 
   // Select option 0.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(0, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
 
   // Remove option 0.
   chooser_controller_->OptionRemoved(base::ASCIIToUTF16("a"));
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
   // |table_view_| should be disabled since there is no option shown.
   ASSERT_FALSE(table_view_.enabled);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   // Since no option selected, the "Connect" button should be disabled.
   ASSERT_FALSE(connect_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, NoOptionSelectedAndPressCancelButton) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
@@ skipping 46 matching lines @@
   chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_ON);
   EXPECT_FALSE(table_view_.hidden);
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   // |table_view_| should be disabled since there is no option shown.
   ASSERT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_TRUE(status_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 
   // Add options
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(3, table_view_.numberOfRows);
   // Select option 1.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
   EXPECT_EQ(1, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 
   chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_OFF);
   EXPECT_FALSE(table_view_.hidden);
   // Since "Bluetooth turned off." needs to be displayed on the |table_view_|,
   // the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   // |table_view_| should be disabled since there is no option shown.
   EXPECT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(l10n_util::GetStringUTF16(IDS_BLUETOOTH_DEVICE_CHOOSER_ADAPTER_OFF),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_TRUE(status_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   // Since the adapter is turned off, the previously selected option
   // becomes invalid, the OK button is disabled.
   EXPECT_EQ(0u, chooser_controller_->NumOptions());
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 
   chooser_controller_->OnAdapterPresenceChanged(
       content::BluetoothChooser::AdapterPresence::POWERED_ON);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_EQ(0u, chooser_controller_->NumOptions());
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, DiscoveringAndNoOptionAddedAndIdle) {
   CreateChooserDialog();
 
   // Add options
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
@@ skipping 25 matching lines @@
   chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::IDLE);
   EXPECT_FALSE(table_view_.hidden);
   // There is no option shown now. But since "No devices found."
   // needs to be displayed on the |table_view_|, the number of rows is 1.
   EXPECT_EQ(1, table_view_.numberOfRows);
   // |table_view_| should be disabled since there is no option shown.
   ASSERT_FALSE(table_view_.enabled);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(
+      l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT),
+      base::SysNSStringToUTF16(
+          [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_TRUE(status_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   // OK button is disabled since the chooser refreshed options.
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest,
        DiscoveringAndOneOptionAddedAndSelectedAndIdle) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:1]
            byExtendingSelection:NO];
 
   chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::DISCOVERING);
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("d"));
   EXPECT_FALSE(table_view_.hidden);
   // |table_view_| should be enabled since there is an option.
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(1, table_view_.numberOfRows);
   // No option selected.
   EXPECT_EQ(-1, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("d"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_FALSE(status_.hidden);
   EXPECT_TRUE(rescan_button_.hidden);
   // OK button is disabled since no option is selected.
   ASSERT_FALSE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_EQ(0, table_view_.selectedRow);
   ASSERT_TRUE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 
   chooser_controller_->OnDiscoveryStateChanged(
       content::BluetoothChooser::DiscoveryState::IDLE);
   EXPECT_FALSE(table_view_.hidden);
   ASSERT_TRUE(table_view_.enabled);
   EXPECT_EQ(1, table_view_.numberOfRows);
   EXPECT_EQ(0, table_view_.selectedRow);
+  EXPECT_EQ(base::ASCIIToUTF16("d"),
+            base::SysNSStringToUTF16(
+                [[table_view_ preparedCellAtColumn:0 row:0] stringValue]));
   EXPECT_TRUE(spinner_.hidden);
   EXPECT_TRUE(status_.hidden);
   EXPECT_FALSE(rescan_button_.hidden);
   ASSERT_TRUE(connect_button_.enabled);
   ASSERT_TRUE(cancel_button_.enabled);
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, PressRescanButton) {
   CreateChooserDialog();
 
   EXPECT_CALL(*chooser_controller_, RefreshOptions()).Times(1);
   [rescan_button_ performClick:chooser_dialog_controller_];
 }
 
 TEST_F(ChooserDialogCocoaControllerTest, PressHelpButton) {
   CreateChooserDialog();
 
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
   chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
 
   // Select option 0 and press "Get help" button.
   [table_view_ selectRowIndexes:[NSIndexSet indexSetWithIndex:0]
            byExtendingSelection:NO];
   EXPECT_CALL(*chooser_controller_, Select(testing::_)).Times(0);
   EXPECT_CALL(*chooser_controller_, Cancel()).Times(0);
   EXPECT_CALL(*chooser_controller_, OpenHelpCenterUrl()).Times(1);
   [help_button_ performClick:chooser_dialog_controller_];
 }