Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2256433002: Merge "Improve line spacing in Clear Browsing Data dialog" (Closed)

Created:
4 years, 4 months ago by jrummell
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "Improve line spacing in Clear Browsing Data dialog" The additional line space needs to apply to the whole text next to the checkbox, rather than just the optional text when selected. Doing this to avoid the text shifting when the checkbox is selected/deselected. BUG=637237 TEST=tested "Clear Browsing Data" dialogs manually CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2240903002 Cr-Commit-Position: refs/heads/master@{#411820} (cherry picked from commit 62e9dd034866c1aa641a6c8280406f1e32e21dbd) Committed: https://chromium.googlesource.com/chromium/src/+/0a8ffdc08c46628f0dee3d70987c4d6d302e6757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/options/clear_browser_data_overlay.css View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
jrummell
4 years, 4 months ago (2016-08-16 20:12:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a8ffdc08c46628f0dee3d70987c4d6d302e6757.

Powered by Google App Engine
This is Rietveld 408576698