Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2240903002: Improve line spacing in Clear Browsing Data dialog (Closed)

Created:
4 years, 4 months ago by jrummell
Modified:
4 years, 4 months ago
Reviewers:
msramek, stevenjb
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve line spacing in Clear Browsing Data dialog The additional line space needs to apply to the whole text next to the checkbox, rather than just the optional text when selected. Doing this to avoid the text shifting when the checkbox is selected/deselected. BUG=637237 TEST=tested "Clear Browsing Data" dialogs manually CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/62e9dd034866c1aa641a6c8280406f1e32e21dbd Cr-Commit-Position: refs/heads/master@{#411820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/options/clear_browser_data_overlay.css View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
jrummell
PTAL. This changes the line spacing to apply to all the text for each checkbox ...
4 years, 4 months ago (2016-08-12 17:33:36 UTC) #3
msramek
LGTM, thanks for following up.
4 years, 4 months ago (2016-08-12 17:43:52 UTC) #6
stevenjb
lgtm
4 years, 4 months ago (2016-08-12 23:30:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2240903002/1
4 years, 4 months ago (2016-08-12 23:39:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 23:45:11 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 23:47:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62e9dd034866c1aa641a6c8280406f1e32e21dbd
Cr-Commit-Position: refs/heads/master@{#411820}

Powered by Google App Engine
This is Rietveld 408576698