ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm ('k') | ios/chrome/browser/google/google_url_tracker_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

diff --git a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

index 219a0ce477da6723a62f37ef7d342ab7fef2aa86..1241d355b00c958904faeb06a00d34f1c673706d 100644

--- a/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

+++ b/ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc

@@ -41,10 +41,10 @@ IOSChromeLargeIconServiceFactory::BuildServiceInstanceFor(

ios::ChromeBrowserState* browser_state =

ios::ChromeBrowserState::FromBrowserState(context);

- return base::WrapUnique(new favicon::LargeIconService(

+ return base::MakeUnique<favicon::LargeIconService>(

ios::FaviconServiceFactory::GetForBrowserState(

browser_state, ServiceAccessType::EXPLICIT_ACCESS),

- web::WebThread::GetBlockingPool()));

+ web::WebThread::GetBlockingPool());

}

web::BrowserState* IOSChromeLargeIconServiceFactory::GetBrowserStateToUse(