ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm - Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm

Issue 2256193002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/favicon/favicon_service_factory.cc ('k') | ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm

diff --git a/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm b/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm

index dc54bf37ef16e274cd71c84df161c93e5fff71af..5b9972612f2c9179d7411256042739f97032f93a 100644

--- a/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm

+++ b/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm

@@ -43,9 +43,9 @@ IOSChromeFaviconLoaderFactory::BuildServiceInstanceFor(

web::BrowserState* context) const {

ios::ChromeBrowserState* browser_state =

ios::ChromeBrowserState::FromBrowserState(context);

- return base::WrapUnique(

- new FaviconLoader(ios::FaviconServiceFactory::GetForBrowserState(

- browser_state, ServiceAccessType::IMPLICIT_ACCESS)));

+ return base::MakeUnique<FaviconLoader>(

+ ios::FaviconServiceFactory::GetForBrowserState(

+ browser_state, ServiceAccessType::IMPLICIT_ACCESS));

}

web::BrowserState* IOSChromeFaviconLoaderFactory::GetBrowserStateToUse(