components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h - Issue 2256183004: Use bookmark creation date fallback for 6 weeks after installing M54

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

Issue 2256183004: Use bookmark creation date fallback for 6 weeks after installing M54 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits from Jan's previous CL 2256643002/#ps20001 Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc » ('j') | components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

index 18f544298ce3a7a282a10f7bdcf4b3f1bf73b2cf..fd893d4ea6756e8173941d3d9511d936aa1a4eb2 100644

--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.h

@@ -31,13 +31,13 @@ void UpdateBookmarkOnURLVisitedInMainFrame(

// bookmark is created also counts. If no info about last visit date is present

// and |creation_date_fallback| is true, creation date is used.

base::Time GetLastVisitDateForBookmark(const bookmarks::BookmarkNode* node,

- bool creation_date_fallback = true);

+ bool creation_date_fallback);

// Like GetLastVisitDateForBookmark, but it returns the unix epoch if the

// bookmark is dismissed from NTP.

base::Time GetLastVisitDateForBookmarkIfNotDismissed(

const bookmarks::BookmarkNode* node,

- bool creation_date_fallback = true);

+ bool creation_date_fallback);

// Marks all bookmarks with the given URL as dismissed.

void MarkBookmarksDismissed(bookmarks::BookmarkModel* bookmark_model,