Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc

Issue 2256183004: Use bookmark creation date fallback for 6 weeks after installing M54 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits from Jan's previous CL 2256643002/#ps20001 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
diff --git a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
index 8283fa2ed73c9133683a18db598099ef8727d37a..9f13fdeac63059c2b7a1abecc15a73fb0d2faf66 100644
--- a/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
+++ b/components/ntp_snippets/bookmarks/bookmark_last_visit_utils.cc
@@ -42,7 +42,8 @@ std::string FormatLastVisitDate(const base::Time& date) {
bool CompareBookmarksByLastVisitDate(const BookmarkNode* a,
const BookmarkNode* b) {
- return GetLastVisitDateForBookmark(a) > GetLastVisitDateForBookmark(b);
+ return GetLastVisitDateForBookmark(a, /*creation_date_fallback=*/true) >
+ GetLastVisitDateForBookmark(b, /*creation_date_fallback=*/true);
}
} // namespace
@@ -71,9 +72,9 @@ base::Time GetLastVisitDateForBookmark(const BookmarkNode* node,
std::string last_visit_date_string;
if (!node->GetMetaInfo(kBookmarkLastVisitDateKey, &last_visit_date_string) &&
- creation_date_fallback)
+ creation_date_fallback) {
return node->date_added();
-
+ }
return ParseLastVisitDate(last_visit_date_string);
}
@@ -141,8 +142,6 @@ std::vector<const BookmarkNode*> GetRecentlyVisitedBookmarks(
std::vector<const BookmarkNode*>::iterator most_recent =
std::min_element(bookmarks_for_url.begin(), bookmarks_for_url.end(),
&CompareBookmarksByLastVisitDate);
- if (most_recent == bookmarks_for_url.end())
- continue;
const BookmarkNode* node = *most_recent;
// Find out if it has been _visited_ recently enough.
@@ -159,7 +158,7 @@ std::vector<const BookmarkNode*> GetRecentlyVisitedBookmarks(
// Fill the list up to |min_count| but do not display more.
max_count = min_count;
} else {
- // Remove the bookmarks that are not recently visited; we do no need them.
+ // Remove the bookmarks that are not recently visited; we do not need them.
bookmarks.erase(
std::remove_if(bookmarks.begin(), bookmarks.end(),
[](const RecentBookmark& bookmark) {

Powered by Google App Engine
This is Rietveld 408576698