content/browser/plugin_private_storage_helper.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/plugin_private_storage_helper.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/platform_notification_context_impl.cc ('k') | content/browser/renderer_host/delegated_frame_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/plugin_private_storage_helper.cc

diff --git a/content/browser/plugin_private_storage_helper.cc b/content/browser/plugin_private_storage_helper.cc

index 3d241ea36b5e0eb0ab8fe2b6bc47c7ebb6c021c7..e58033ccfe8a8ccf150e231dbe583bbe026370d8 100644

--- a/content/browser/plugin_private_storage_helper.cc

+++ b/content/browser/plugin_private_storage_helper.cc

@@ -142,8 +142,8 @@ void PluginPrivateDataByOriginChecker::OnFileSystemOpened(

std::string root = storage::GetIsolatedFileSystemRootURIString(

origin_, fsid_, ppapi::kPluginPrivateRootName);

std::unique_ptr<storage::FileSystemOperationContext> operation_context =

- base::WrapUnique(

- new storage::FileSystemOperationContext(filesystem_context_));

+ base::MakeUnique<storage::FileSystemOperationContext>(

+ filesystem_context_);

file_util->ReadDirectory(

std::move(operation_context), filesystem_context_->CrackURL(GURL(root)),

base::Bind(&PluginPrivateDataByOriginChecker::OnDirectoryRead,

@@ -177,8 +177,8 @@ void PluginPrivateDataByOriginChecker::OnDirectoryRead(

DCHECK(!file.is_directory); // Nested directories not implemented.

std::unique_ptr<storage::FileSystemOperationContext> operation_context =

- base::WrapUnique(

- new storage::FileSystemOperationContext(filesystem_context_));

+ base::MakeUnique<storage::FileSystemOperationContext>(

+ filesystem_context_);

storage::FileSystemURL file_url = filesystem_context_->CrackURL(

GURL(root + StringTypeToString(file.name)));

IncrementTaskCount();