content/browser/notifications/platform_notification_context_impl.cc - Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/platform_notification_context_impl.cc

Issue 2256173002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace a WrapUnique() nested inside a MakeUnique() Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/media/capture/web_contents_video_capture_device_unittest.cc ('k') | content/browser/plugin_private_storage_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/platform_notification_context_impl.cc

diff --git a/content/browser/notifications/platform_notification_context_impl.cc b/content/browser/notifications/platform_notification_context_impl.cc

index f986fa8a6ea6ba03b5b47f99d24005c2d7d9f223..6a777cc7949e9b693f55d1ca9dea9babf8332a27 100644

--- a/content/browser/notifications/platform_notification_context_impl.cc

+++ b/content/browser/notifications/platform_notification_context_impl.cc

@@ -120,8 +120,8 @@ void PlatformNotificationContextImpl::CreateServiceOnIO(

ResourceContext* resource_context,

mojo::InterfaceRequest<blink::mojom::NotificationService> request) {

DCHECK_CURRENTLY_ON(BrowserThread::IO);

- services_.push_back(base::WrapUnique(new BlinkNotificationServiceImpl(

- this, resource_context, render_process_id, std::move(request))));

+ services_.push_back(base::MakeUnique<BlinkNotificationServiceImpl>(

+ this, resource_context, render_process_id, std::move(request)));

}

void PlatformNotificationContextImpl::RemoveService(