Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2256093002: Roll isolate go to binaries as generated by infra @ 6f3db5a82956. (Closed)

Created:
4 years, 4 months ago by M-A Ruel
Modified:
4 years, 4 months ago
CC:
chromium-reviews, tandrii(chromium)
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll isolate go to binaries as generated by infra @ 6f3db5a82956. Which is luci-go @ e438e8c3b563e48aaccca7bd0f4997ef29174e3d TBR=tansell@chromium.org BUG=598990 Committed: https://crrev.com/a7ce77dda519428ce58039382485c7cd0cc05ab7 Cr-Commit-Position: refs/heads/master@{#412819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
M-A Ruel
I got the hashes from https://build.chromium.org/p/chromium.infra/waterfall Sorry for the delay. All instances have been updated ...
4 years, 4 months ago (2016-08-18 02:28:26 UTC) #1
M-A Ruel
TBR'ing, adding Andrii, this CL is easy to revert if there is a problem and ...
4 years, 4 months ago (2016-08-18 13:56:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256093002/1
4 years, 4 months ago (2016-08-18 13:56:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 14:00:22 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a7ce77dda519428ce58039382485c7cd0cc05ab7 Cr-Commit-Position: refs/heads/master@{#412819}
4 years, 4 months ago (2016-08-18 14:02:22 UTC) #13
tandrii(chromium)
lgtm
4 years, 4 months ago (2016-08-18 14:20:04 UTC) #15
jam
4 years, 3 months ago (2016-09-14 19:17:44 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2345553002/ by jam@chromium.org.

The reason for reverting is: This is causing isolate step to be much slower per
https://bugs.chromium.org/p/chromium/issues/detail?id=644410.

Powered by Google App Engine
This is Rietveld 408576698