Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2256083003: Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection (Closed)

Created:
4 years, 4 months ago by Will Harris
Modified:
4 years, 4 months ago
Reviewers:
tkent, yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection (patchset #3 id:80001 of https://codereview.chromium.org/2021793002/ ) Reason for revert: this is causing hangs on latest canary. crbug.com/638868 Original issue's description: > [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection > > This CL is updated of reverted one: > https://codereview.chromium.org/2001993002 > > This CL considers the reverted shadow boundary issue. > > BUG=481985 > > Committed: https://crrev.com/08acdf950e1776571def8e6f16c288769e7e9e27 > Cr-Commit-Position: refs/heads/master@{#412457} TBR=tkent@chromium.org,yosin@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=481985, 638868 Committed: https://crrev.com/29cd7243aa6537f9e1517568a299e8187bb3b230 Cr-Commit-Position: refs/heads/master@{#412903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -58 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/mouse/drag_user_select_none.html View 2 chunks +13 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/mouse/select_user_select_in_shadow.html View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +7 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Will Harris
Created Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection
4 years, 4 months ago (2016-08-18 17:22:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2256083003/1
4 years, 4 months ago (2016-08-18 17:23:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 18:54:51 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 18:57:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29cd7243aa6537f9e1517568a299e8187bb3b230
Cr-Commit-Position: refs/heads/master@{#412903}

Powered by Google App Engine
This is Rietveld 408576698