Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2001993002: [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection (Closed)

Created:
4 years, 7 months ago by yoichio
Modified:
4 years, 7 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drag from a -webkit-user-select:none element should not start selection BUG=481985 TEST=LayoutTests/editing/selection/mouse/drag_user_select_none.html Committed: https://crrev.com/f6dcdcf4917ba56f5576ef7d5d11d869630d2760 Cr-Commit-Position: refs/heads/master@{#395856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/mouse/drag_user_select_none.html View 2 chunks +7 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
yosin_UTC9
lgtm
4 years, 7 months ago (2016-05-24 08:31:36 UTC) #3
yoichio
4 years, 7 months ago (2016-05-24 09:00:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001993002/1
4 years, 7 months ago (2016-05-25 02:10:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189330)
4 years, 7 months ago (2016-05-25 02:17:46 UTC) #8
yoichio
Add tkent for owner.
4 years, 7 months ago (2016-05-25 06:46:03 UTC) #10
tkent
lgtm
4 years, 7 months ago (2016-05-25 06:53:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001993002/1
4 years, 7 months ago (2016-05-25 07:56:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 10:24:39 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6dcdcf4917ba56f5576ef7d5d11d869630d2760 Cr-Commit-Position: refs/heads/master@{#395856}
4 years, 7 months ago (2016-05-25 10:26:11 UTC) #17
luoe
4 years, 6 months ago (2016-05-26 21:52:35 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2014393002/ by luoe@chromium.org.

The reason for reverting is: This breaks text selection in the DevTools console
when trying to select logged text.

https://bugs.chromium.org/p/chromium/issues/detail?id=615227.

Powered by Google App Engine
This is Rietveld 408576698