Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 2256053002: Fix notification button background size (Closed)

Created:
4 years, 4 months ago by yoshiki
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 Review-Url: https://codereview.chromium.org/2247893002 Cr-Commit-Position: refs/heads/master@{#412060} (cherry picked from commit e311188e565ea85ccc4ad8f0aeee03eab488bb23) Committed: https://chromium.googlesource.com/chromium/src/+/9c1257266665f6b80473a17347edfda7fd7f57f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ash/common/system/web_notification/web_notification_tray.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
yoshiki
4 years, 4 months ago (2016-08-18 01:15:25 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c1257266665f6b80473a17347edfda7fd7f57f9.

Powered by Google App Engine
This is Rietveld 408576698