Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2247893002:
Fix notification button background size (Closed)
DescriptionFix notification button background size
In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView
to adjust the size of notification button background; however, this adjustment
is later cancelled by re-setting border to NULL. As a result, the background
is incorrect as shelf alignment changes.
BUG=637882
Committed: https://crrev.com/e311188e565ea85ccc4ad8f0aeee03eab488bb23
Cr-Commit-Position: refs/heads/master@{#412060}
Patch Set 1 #Patch Set 2 : update separator color #Messages
Total messages: 17 (11 generated)
Description was changed from ========== fix BUG=637882 ========== to ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. BUG=637882 ==========
yiyix@chromium.org changed reviewers: + jamescook@google.com, tdanderson@chromium.org
@tdanderson and @jamescook, could you take a look at this short change?
Description was changed from ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. BUG=637882 ========== to ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. BUG=637882 ==========
yiyix@chromium.org changed reviewers: + jamescook@chromium.org - jamescook@google.com
LGTM with a more detail in the CL description as discussed in person.
Description was changed from ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. BUG=637882 ========== to ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. BUG=637882 ==========
Description was changed from ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. BUG=637882 ========== to ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. It bug is fixed by removing the border size adjustment. BUG=637882 ==========
LGTM. You might want to ping or cc the author of the CL that added those border changes (bruthig? estade?)
Description was changed from ========== Fix notification button background size When Shelf alignment changes, the notification button background is not being updated accordingly. In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. It bug is fixed by removing the border size adjustment. BUG=637882 ========== to ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. BUG=637882 ==========
Description was changed from ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. BUG=637882 ========== to ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 ==========
The CQ bit was checked by yiyix@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 ========== to ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 ========== to ========== Fix notification button background size In CL2243563002, a new variable |margin_| was introduced to TrayBackgroundView to adjust the size of notification button background; however, this adjustment is later cancelled by re-setting border to NULL. As a result, the background is incorrect as shelf alignment changes. BUG=637882 Committed: https://crrev.com/e311188e565ea85ccc4ad8f0aeee03eab488bb23 Cr-Commit-Position: refs/heads/master@{#412060} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e311188e565ea85ccc4ad8f0aeee03eab488bb23 Cr-Commit-Position: refs/heads/master@{#412060} |
