Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2255973005: Blink-compatible serialization of dates. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of dates. BUG=chromium:148757 Committed: https://crrev.com/cff8e03d4de432fbc7411da6055faf37e2a88086 Cr-Commit-Position: refs/heads/master@{#38795}

Patch Set 1 #

Patch Set 2 : forgot the decode tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -0 lines) Patch
M src/value-serializer.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 5 chunks +25 lines, -0 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
jbroman
4 years, 4 months ago (2016-08-19 15:07:29 UTC) #4
Jakob Kummerow
LGTM. Dates are JSObjects and can have additional properties, which won't get serialized by this, ...
4 years, 4 months ago (2016-08-22 15:53:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255973005/20001
4 years, 4 months ago (2016-08-22 16:41:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 17:14:39 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 17:15:11 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cff8e03d4de432fbc7411da6055faf37e2a88086
Cr-Commit-Position: refs/heads/master@{#38795}

Powered by Google App Engine
This is Rietveld 408576698