third_party/WebKit/Source/modules/quota/StorageManager.cpp - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Unified Diff: third_party/WebKit/Source/modules/quota/StorageManager.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Demonstrate PermissionDescriptor extensibility with MIDI. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/permissions/PermissionStatus.h ('K') | « third_party/WebKit/Source/modules/permissions/Permissions.cpp ('k') | third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h » ('j') | third_party/WebKit/public/platform/modules/permissions/permission.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/quota/StorageManager.cpp

diff --git a/third_party/WebKit/Source/modules/quota/StorageManager.cpp b/third_party/WebKit/Source/modules/quota/StorageManager.cpp

index df590c75a4dd0771835cfce212789a1c4a6f6ca3..b26f1992fc00f6a534ad74e9678995254a09609f 100644

--- a/third_party/WebKit/Source/modules/quota/StorageManager.cpp

+++ b/third_party/WebKit/Source/modules/quota/StorageManager.cpp

@@ -81,7 +81,9 @@ ScriptPromise StorageManager::persist(ScriptState* scriptState)

resolver->reject(DOMException::create(InvalidStateError, "In its current state, the global scope can't request permissions."));

return promise;

}

- permissionService->RequestPermission(PermissionName::DURABLE_STORAGE, scriptState->getExecutionContext()->getSecurityOrigin(), UserGestureIndicator::processingUserGesture(), convertToBaseCallback(WTF::bind(&StorageManager::permissionRequestComplete, wrapPersistent(this), wrapPersistent(resolver))));

+ auto descriptor = mojom::blink::PermissionDescriptor::New();

+ descriptor->name = PermissionName::DURABLE_STORAGE;

+ permissionService->RequestPermission(std::move(descriptor), scriptState->getExecutionContext()->getSecurityOrigin(), UserGestureIndicator::processingUserGesture(), convertToBaseCallback(WTF::bind(&StorageManager::permissionRequestComplete, wrapPersistent(this), wrapPersistent(resolver))));

return promise;

}

@@ -95,7 +97,9 @@ ScriptPromise StorageManager::persisted(ScriptState* scriptState)

resolver->reject(DOMException::create(InvalidStateError, "In its current state, the global scope can't query permissions."));

return promise;

}

- permissionService->HasPermission(PermissionName::DURABLE_STORAGE, scriptState->getExecutionContext()->getSecurityOrigin(), convertToBaseCallback(WTF::bind(&StorageManager::permissionRequestComplete, wrapPersistent(this), wrapPersistent(resolver))));

+ auto descriptor = mojom::blink::PermissionDescriptor::New();

+ descriptor->name = PermissionName::DURABLE_STORAGE;

+ permissionService->HasPermission(std::move(descriptor), scriptState->getExecutionContext()->getSecurityOrigin(), convertToBaseCallback(WTF::bind(&StorageManager::permissionRequestComplete, wrapPersistent(this), wrapPersistent(resolver))));

return promise;

}