third_party/WebKit/Source/modules/permissions/PermissionStatus.h - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Unified Diff: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Demonstrate PermissionDescriptor extensibility with MIDI. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/notification_permission_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/geolocation/Geolocation.cpp ('k') | third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp » ('j') | third_party/WebKit/public/platform/modules/permissions/permission.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/permissions/PermissionStatus.h

diff --git a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

index ec02f77c6aa012abdb8721ffd90711747cc427d5..b7d93ec69cafc4cc297df1dd5e636fdc987f813a 100644

--- a/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

+++ b/third_party/WebKit/Source/modules/permissions/PermissionStatus.h

@@ -27,13 +27,13 @@ class PermissionStatus final

USING_GARBAGE_COLLECTED_MIXIN(PermissionStatus);

DEFINE_WRAPPERTYPEINFO();

- using MojoPermissionName = mojom::blink::PermissionName;

+ using MojoPermissionDescriptor = mojom::blink::PermissionDescriptorPtr;

using MojoPermissionStatus = mojom::blink::PermissionStatus;

public:

- static PermissionStatus* take(ScriptPromiseResolver*, MojoPermissionStatus, MojoPermissionName);

+ static PermissionStatus* take(ScriptPromiseResolver*, MojoPermissionStatus, MojoPermissionDescriptor);

- static PermissionStatus* createAndListen(ExecutionContext*, MojoPermissionStatus, MojoPermissionName);

+ static PermissionStatus* createAndListen(ExecutionContext*, MojoPermissionStatus, MojoPermissionDescriptor);

~PermissionStatus() override;

// EventTarget implementation.

@@ -49,20 +49,20 @@ public:

void stop() override;

String state() const;

- void permissionChanged(mojom::blink::PermissionStatus);

+ void permissionChanged(MojoPermissionStatus);

DEFINE_ATTRIBUTE_EVENT_LISTENER(change);

DECLARE_VIRTUAL_TRACE();

private:

- PermissionStatus(ExecutionContext*, MojoPermissionStatus, MojoPermissionName);

+ PermissionStatus(ExecutionContext*, MojoPermissionStatus, MojoPermissionDescriptor);

void startListening();

void stopListening();

MojoPermissionStatus m_status;

- MojoPermissionName m_name;

+ MojoPermissionDescriptor m_query;

mlamouri (slow - plz ping) 2016/08/26 17:19:29 nit: m_descriptor?

Reilly Grant (use Gerrit) 2016/08/26 18:17:15 I stole the word "query" from the Permission API s

mojom::blink::PermissionServicePtr m_service;

};