third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Demonstrate PermissionDescriptor extensibility with MIDI. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/notification_permission_dispatcher.cc ('K') | « content/renderer/notification_permission_dispatcher.cc ('k') | third_party/WebKit/Source/modules/permissions/PermissionStatus.h » ('j') | third_party/WebKit/Source/modules/permissions/PermissionStatus.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index cd8df3c870ffe60090e87a18ad276bf98cb8bf77..149be46407c3fffe1049dc7295f5fba9640ec6b4 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -426,8 +426,10 @@ void Geolocation::requestPermission()

m_permissionService.set_connection_error_handler(convertToBaseCallback(WTF::bind(&Geolocation::onPermissionConnectionError, wrapWeakPersistent(this))));

// Ask the embedder: it maintains the geolocation challenge policy itself.

+ auto descriptor = mojom::blink::PermissionDescriptor::New();

+ descriptor->name = mojom::blink::PermissionName::GEOLOCATION;

m_permissionService->RequestPermission(

- mojom::blink::PermissionName::GEOLOCATION,

+ std::move(descriptor),

getExecutionContext()->getSecurityOrigin(),

UserGestureIndicator::processingUserGesture(),

convertToBaseCallback(WTF::bind(&Geolocation::onGeolocationPermissionUpdated, wrapPersistent(this))));