third_party/WebKit/Source/modules/geolocation/Geolocation.cpp - Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher

Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/geolocation/DEPS ('k') | third_party/WebKit/Source/modules/notifications/NotificationManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

index e8138a5098de9bdc2352cb2b133cc20c026e5184..88d7796178f4275fc857df3a62308029eb2ec34c 100644

--- a/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

@@ -33,8 +33,8 @@

#include "core/frame/Settings.h"

#include "modules/geolocation/Coordinates.h"

#include "modules/geolocation/GeolocationError.h"

+#include "modules/permissions/PermissionUtils.h"

#include "platform/UserGestureIndicator.h"

-#include "platform/mojo/MojoHelper.h"

#include "public/platform/InterfaceProvider.h"

#include "public/platform/Platform.h"

#include "wtf/Assertions.h"

@@ -432,7 +432,7 @@ void Geolocation::requestPermission() {

// Ask the embedder: it maintains the geolocation challenge policy itself.

m_permissionService->RequestPermission(

- mojom::blink::PermissionName::GEOLOCATION,

+ createPermissionDescriptor(mojom::blink::PermissionName::GEOLOCATION),

getExecutionContext()->getSecurityOrigin(),

UserGestureIndicator::processingUserGesture(),

convertToBaseCallback(WTF::bind(