Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: third_party/WebKit/Source/modules/geolocation/Geolocation.cpp

Issue 2255933002: Add PermissionDescriptor to the permissions Mojo interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no_notification_dispatcher
Patch Set: Print the unexpected permission type. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2009 Torch Mobile, Inc. 3 * Copyright (C) 2009 Torch Mobile, Inc.
4 * Copyright 2010, The Android Open Source Project 4 * Copyright 2010, The Android Open Source Project
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 15 matching lines...) Expand all
26 */ 26 */
27 27
28 #include "modules/geolocation/Geolocation.h" 28 #include "modules/geolocation/Geolocation.h"
29 29
30 #include "core/dom/Document.h" 30 #include "core/dom/Document.h"
31 #include "core/frame/Deprecation.h" 31 #include "core/frame/Deprecation.h"
32 #include "core/frame/HostsUsingFeatures.h" 32 #include "core/frame/HostsUsingFeatures.h"
33 #include "core/frame/Settings.h" 33 #include "core/frame/Settings.h"
34 #include "modules/geolocation/Coordinates.h" 34 #include "modules/geolocation/Coordinates.h"
35 #include "modules/geolocation/GeolocationError.h" 35 #include "modules/geolocation/GeolocationError.h"
36 #include "modules/permissions/PermissionUtils.h"
36 #include "platform/UserGestureIndicator.h" 37 #include "platform/UserGestureIndicator.h"
37 #include "platform/mojo/MojoHelper.h"
38 #include "public/platform/InterfaceProvider.h" 38 #include "public/platform/InterfaceProvider.h"
39 #include "public/platform/Platform.h" 39 #include "public/platform/Platform.h"
40 #include "wtf/Assertions.h" 40 #include "wtf/Assertions.h"
41 #include "wtf/CurrentTime.h" 41 #include "wtf/CurrentTime.h"
42 42
43 namespace blink { 43 namespace blink {
44 namespace { 44 namespace {
45 45
46 static const char permissionDeniedErrorMessage[] = "User denied Geolocation"; 46 static const char permissionDeniedErrorMessage[] = "User denied Geolocation";
47 static const char failedToStartServiceErrorMessage[] = 47 static const char failedToStartServiceErrorMessage[] =
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 425
426 m_geolocationPermission = PermissionRequested; 426 m_geolocationPermission = PermissionRequested;
427 frame->interfaceProvider()->getInterface( 427 frame->interfaceProvider()->getInterface(
428 mojo::GetProxy(&m_permissionService)); 428 mojo::GetProxy(&m_permissionService));
429 m_permissionService.set_connection_error_handler( 429 m_permissionService.set_connection_error_handler(
430 convertToBaseCallback(WTF::bind(&Geolocation::onPermissionConnectionError, 430 convertToBaseCallback(WTF::bind(&Geolocation::onPermissionConnectionError,
431 wrapWeakPersistent(this)))); 431 wrapWeakPersistent(this))));
432 432
433 // Ask the embedder: it maintains the geolocation challenge policy itself. 433 // Ask the embedder: it maintains the geolocation challenge policy itself.
434 m_permissionService->RequestPermission( 434 m_permissionService->RequestPermission(
435 mojom::blink::PermissionName::GEOLOCATION, 435 createPermissionDescriptor(mojom::blink::PermissionName::GEOLOCATION),
436 getExecutionContext()->getSecurityOrigin(), 436 getExecutionContext()->getSecurityOrigin(),
437 UserGestureIndicator::processingUserGesture(), 437 UserGestureIndicator::processingUserGesture(),
438 convertToBaseCallback(WTF::bind( 438 convertToBaseCallback(WTF::bind(
439 &Geolocation::onGeolocationPermissionUpdated, wrapPersistent(this)))); 439 &Geolocation::onGeolocationPermissionUpdated, wrapPersistent(this))));
440 } 440 }
441 441
442 void Geolocation::makeSuccessCallbacks() { 442 void Geolocation::makeSuccessCallbacks() {
443 DCHECK(m_lastPosition); 443 DCHECK(m_lastPosition);
444 DCHECK(isAllowed()); 444 DCHECK(isAllowed());
445 445
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
548 // be called. In that case, blink has already shut down so do nothing. 548 // be called. In that case, blink has already shut down so do nothing.
549 // 549 //
550 // TODO(sammc): Remove this once renderer shutdown is no longer graceful. 550 // TODO(sammc): Remove this once renderer shutdown is no longer graceful.
551 if (!Platform::current()) 551 if (!Platform::current())
552 return; 552 return;
553 553
554 onGeolocationPermissionUpdated(mojom::blink::PermissionStatus::DENIED); 554 onGeolocationPermissionUpdated(mojom::blink::PermissionStatus::DENIED);
555 } 555 }
556 556
557 } // namespace blink 557 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698