Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2255873002: Setup VR builder and tester (Closed)

Created:
4 years, 4 months ago by bsheedy
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change chromium.fyi 'Android Builder (dbg)' to compile VR by adding "enable_vr_shell" build flag. Add setup for new test slave "Android VR Tests'. Corresponding buildbot/infra related changes can be reviewed at https://codereview.chromium.org/2293803004 BUG= Committed: https://crrev.com/04925ca1db4950d5e245a75458955f66cd535c6b Cr-Commit-Position: refs/heads/master@{#415720}

Patch Set 1 #

Patch Set 2 : Setup for Hoverboard test slave #

Total comments: 1

Patch Set 3 : Removed empty gtest_tests list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M testing/buildbot/chromium.fyi.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/mb/mb_config.pyl View 1 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Paweł Hajdan Jr.
https://codereview.chromium.org/2255873002/diff/20001/testing/buildbot/chromium.fyi.json File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2255873002/diff/20001/testing/buildbot/chromium.fyi.json#newcode789 testing/buildbot/chromium.fyi.json:789: "Android VR Tests": { This shouldn't be needed.
4 years, 3 months ago (2016-08-31 08:42:08 UTC) #7
Dirk Pranke
lgtm w/ phajdan.jr's edit made.
4 years, 3 months ago (2016-08-31 16:16:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255873002/40001
4 years, 3 months ago (2016-08-31 17:57:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 19:19:57 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 19:21:47 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/04925ca1db4950d5e245a75458955f66cd535c6b
Cr-Commit-Position: refs/heads/master@{#415720}

Powered by Google App Engine
This is Rietveld 408576698