Infra setup for Hoverboard test slave

Infra setup for Hoverboard test slave

Buildbot-side setup for setting up a testing slave for Hoverboard
(Chrome VR). Adds a new builder definition for 'Android VR Tests'
and defines a new slave.

Slave setup ticket is https://bugs.chromium.org/p/chromium/issues/detail?id=639014&can=2&start=0&num=100&q=owner%3Ame&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=

Corresponding config file changes in the Chromium repository can be reviewed at
https://codereview.chromium.org/2255873002/

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/build/+/28fb0ce5c14fe54c9372a3726b629928afc5bd79

[Paweł Hajdan Jr., 2016-08-31 08:40:15]

phajdan.jr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2016-08-31 08:40:15]

LGTM

[jbudorick, 2016-09-01 18:48:01]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2016-09-01 18:48:01]

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2196: 'TARGET_BITS':
32,
You shouldn't need to set TARGET_BITS.

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2201:
'android_config': 'arm64_builder_mb'
I know I said to switch this from main_builder_mb, but with this triggering off
of an arm builder rather than an arm64 builder, I might have been wrong. (I
don't think we have any bots that do this at the moment.)

[bsheedy, 2016-09-01 21:24:26]

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py (right):

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2196: 'TARGET_BITS':
32,
On 2016/09/01 18:48:01, jbudorick wrote:
> You shouldn't need to set TARGET_BITS.

Done.

https://codereview.chromium.org/2293803004/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py:2201:
'android_config': 'arm64_builder_mb'
On 2016/09/01 18:48:01, jbudorick wrote:
> I know I said to switch this from main_builder_mb, but with this triggering
off
> of an arm builder rather than an arm64 builder, I might have been wrong. (I
> don't think we have any bots that do this at the moment.)

Done.

[jbudorick, 2016-09-01 21:26:34]

lgtm

[bsheedy, 2016-09-02 16:40:17]

The CQ bit was checked by bsheedy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 16:40:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 16:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 16:43:52]

Dry run: This issue passed the CQ dry run.

[bsheedy, 2016-09-02 16:56:53]

I'll hold off on committing until someone takes another look even though the
added files are just generated output. I'd prefer to not accidentally kill the
Chromium infrastructure due to assuming its correctness.

[jbudorick, 2016-09-02 16:58:50]

lgtm

[jbudorick, 2016-09-02 16:59:49]

On 2016/09/02 16:56:53, bsheedy wrote:
> I'll hold off on committing until someone takes another look even though the
> added files are just generated output. I'd prefer to not accidentally kill the
> Chromium infrastructure due to assuming its correctness.

This is a pretty low-risk change, but your caution and consideration are
appreciated :)

[bsheedy, 2016-09-02 17:00:16]

The CQ bit was checked by bsheedy@chromium.org

[bsheedy, 2016-09-02 17:00:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2293803004/#ps60001
(title: "Added recipes.py output, fixed comma")

[commit-bot: I haz the power, 2016-09-02 17:00:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 17:04:47]

Description was changed from

==========
Infra setup for Hoverboard test slave

Buildbot-side setup for setting up a testing slave for Hoverboard
(Chrome VR). Adds a new builder definition for 'Android VR Tests'
and defines a new slave.

Slave setup ticket is
https://bugs.chromium.org/p/chromium/issues/detail?id=639014&can=2&start=0&nu...

Corresponding config file changes in the Chromium repository can be reviewed at
https://codereview.chromium.org/2255873002/

BUG=
==========

to

==========
Infra setup for Hoverboard test slave

Buildbot-side setup for setting up a testing slave for Hoverboard
(Chrome VR). Adds a new builder definition for 'Android VR Tests'
and defines a new slave.

Slave setup ticket is
https://bugs.chromium.org/p/chromium/issues/detail?id=639014&can=2&start=0&nu...

Corresponding config file changes in the Chromium repository can be reviewed at
https://codereview.chromium.org/2255873002/

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/28fb0ce5c14fe54c9372...
==========

[commit-bot: I haz the power, 2016-09-02 17:04:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/28fb0ce5c14fe54c9372...