Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2255843002: Factor out the duplicated logic in Field::SetDisplay (Closed)

Created:
1 year, 3 months ago by tonikitoo
Modified:
1 year, 3 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Factor out the duplicated logic in Field::SetDisplay CL introduces a helper function to share the common logic. No new tests, since there is no behavior change. Committed: https://pdfium.googlesource.com/pdfium/+/7c05a7ac2738ef5e80692d5e3d2db68b86f27ea4

Patch Set 1 #

Total comments: 9

Patch Set 2 : Factor out the duplicated logic in Field::SetDisplay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -70 lines) Patch
M fpdfsdk/javascript/Field.cpp View 1 2 chunks +55 lines, -70 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
tonikitoo
PTAL
1 year, 3 months ago (2016-08-17 17:23:46 UTC) #3
Tom Sepez
Very nice. Just a few style things. Thanks for your contribution. https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp File fpdfsdk/javascript/Field.cpp (right): ...
1 year, 3 months ago (2016-08-17 17:33:31 UTC) #4
Tom Sepez
https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp File fpdfsdk/javascript/Field.cpp (right): https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp#newcode1286 fpdfsdk/javascript/Field.cpp:1286: bSet = SetWidgetDisplayStatus(pWidget, number); actually, we don't want to ...
1 year, 3 months ago (2016-08-17 17:38:40 UTC) #5
tonikitoo
On 2016/08/17 17:38:40, Tom Sepez wrote: > https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp > File fpdfsdk/javascript/Field.cpp (right): > > https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp#newcode1286 ...
1 year, 3 months ago (2016-08-17 17:40:48 UTC) #6
Tom Sepez
Perpetual twiddling. Feel free to ignore. https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp File fpdfsdk/javascript/Field.cpp (right): https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp#newcode1280 fpdfsdk/javascript/Field.cpp:1280: FX_BOOL bSet = ...
1 year, 3 months ago (2016-08-17 17:45:37 UTC) #7
tonikitoo
https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp File fpdfsdk/javascript/Field.cpp (right): https://codereview.chromium.org/2255843002/diff/1/fpdfsdk/javascript/Field.cpp#newcode29 fpdfsdk/javascript/Field.cpp:29: static bool SetWidgetDisplayStatus(CPDFSDK_Widget* pWidget, int value) { On 2016/08/17 ...
1 year, 3 months ago (2016-08-17 17:51:53 UTC) #8
Tom Sepez
lgtm
1 year, 3 months ago (2016-08-17 17:55:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255843002/20001
1 year, 3 months ago (2016-08-17 17:55:39 UTC) #11
commit-bot: I haz the power
1 year, 3 months ago (2016-08-17 18:08:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7c05a7ac2738ef5e80692d5e3d2db68b86f2...

Powered by Google App Engine
This is Rietveld efc10ee0f