Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2255763002: check for null bitmap (Closed)

Created:
4 years, 4 months ago by caryclark
Modified:
4 years, 4 months ago
Reviewers:
dsinclair, =dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

check for null bitmap Recent Skia driver addition of 8 bit src / 8 bit dst workaround needs to check for a nullptr bitmap. R==dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8ca0f059bb13a12d50a8a4f3a6e4b3c91cfa570e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M core/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
caryclark
4 years, 4 months ago (2016-08-17 13:42:49 UTC) #1
dsinclair
lgtm
4 years, 4 months ago (2016-08-17 14:13:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2255763002/1
4 years, 4 months ago (2016-08-17 14:13:40 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 14:34:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/8ca0f059bb13a12d50a8a4f3a6e4b3c91cfa...

Powered by Google App Engine
This is Rietveld 408576698