Remove unused histograms for QUIC

Remove histograms:
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013
Committed: https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe
Cr-Commit-Position: refs/heads/master@{#412976}

[Zhongyi Shi, 2016-08-17 23:36:14]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 23:36:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhongyi Shi, 2016-08-17 23:51:24]

zhongyi@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[Ryan Hamilton, 2016-08-17 23:55:15]

Might as well just nuke all of these wonky histograms that we're no longer
using.

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
File net/quic/chromium/quic_connection_logger.cc (right):

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
net/quic/chromium/quic_connection_logger.cc:803: base::HistogramBase*
six_packet_histogram = Get6PacketHistogram("Some6s_");
I think you can get rid of all the histograms on line 795-803, fwiw.

[Zhongyi Shi, 2016-08-18 01:09:46]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 01:10:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 02:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 02:19:40]

Dry run: This issue passed the CQ dry run.

[Zhongyi Shi, 2016-08-18 03:56:04]

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
File net/quic/chromium/quic_connection_logger.cc (right):

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
net/quic/chromium/quic_connection_logger.cc:803: base::HistogramBase*
six_packet_histogram = Get6PacketHistogram("Some6s_");
On 2016/08/17 23:55:15, Ryan Hamilton wrote:
> I think you can get rid of all the histograms on line 795-803, fwiw.

Do we also want to remove the last one? All the other histograms are okay to
move as we didn't look at them. Not sure whether someone else is looking at the
last ones.

[Ryan Hamilton, 2016-08-18 04:05:21]

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
File net/quic/chromium/quic_connection_logger.cc (right):

https://codereview.chromium.org/2255753003/diff/1/net/quic/chromium/quic_conn...
net/quic/chromium/quic_connection_logger.cc:803: base::HistogramBase*
six_packet_histogram = Get6PacketHistogram("Some6s_");
On 2016/08/18 03:56:04, Zhongyi Shi wrote:
> On 2016/08/17 23:55:15, Ryan Hamilton wrote:
> > I think you can get rid of all the histograms on line 795-803, fwiw.
> 
> Do we also want to remove the last one? All the other histograms are okay to
> move as we didn't look at them. Not sure whether someone else is looking at
the
> last ones.

You could ask on quic-dev, though I suspect it's really unused.

[Alexei Svitkine (slow), 2016-08-18 05:51:53]

lgtm

[Zhongyi Shi, 2016-08-18 18:36:22]

Description was changed from

==========
Remove histograms: Net.QuicSession.PacketReceived_IsAnAck_Connection_*

BUG=612228
==========

to

==========
Remove histograms: 
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013
==========

[Zhongyi Shi, 2016-08-18 19:16:35]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 19:17:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-08-18 19:36:33]

lgtm, mod one tweak

https://codereview.chromium.org/2255753003/diff/40001/net/quic/chromium/quic_...
File net/quic/chromium/quic_connection_logger.cc (right):

https://codereview.chromium.org/2255753003/diff/40001/net/quic/chromium/quic_...
net/quic/chromium/quic_connection_logger.cc:345: if
(largest_received_packet_number_ != 0)
Is this check needed, since the method already checks:

if (largest_received_packet_number_ <= 21)
  return;

[Zhongyi Shi, 2016-08-18 20:13:11]

https://codereview.chromium.org/2255753003/diff/40001/net/quic/chromium/quic_...
File net/quic/chromium/quic_connection_logger.cc (right):

https://codereview.chromium.org/2255753003/diff/40001/net/quic/chromium/quic_...
net/quic/chromium/quic_connection_logger.cc:345: if
(largest_received_packet_number_ != 0)
On 2016/08/18 19:36:33, Ryan Hamilton wrote:
> Is this check needed, since the method already checks:
> 
> if (largest_received_packet_number_ <= 21)
>   return;
> 

Ah, yeah, this can be removed. Removed.

[Zhongyi Shi, 2016-08-18 20:13:21]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2016-08-18 20:13:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2255753003/#ps60001
(title: "remove a if condition")

[commit-bot: I haz the power, 2016-08-18 20:13:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 22:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:50:34]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhongyi Shi, 2016-08-18 22:53:12]

The CQ bit was checked by zhongyi@chromium.org

[commit-bot: I haz the power, 2016-08-18 22:54:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 00:00:21]

Description was changed from

==========
Remove histograms: 
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013
==========

to

==========
Remove histograms: 
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013
==========

[commit-bot: I haz the power, 2016-08-19 00:00:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 00:02:56]

Description was changed from

==========
Remove histograms: 
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013
==========

to

==========
Remove histograms:
Net.QuicSession.6PacketsPatternsReceived*
Net.QuicSession.21CumulativePacketsReceived_Some21s_*
Net.QuicSession.21CumulativePacketsReceived_First21_*
Net.QuicSession.PacketReceived_IsNotAck_CONNECTION_*
Net.QuicSession.PacketReceived_IsAnAck_CONNECTION_*
Net.QuicSession.PacketReceived_Ack_CONNECTION_*
Net.QuicSession.PacketReceived_Nack_CONNECTION_*

BUG=639013

Committed: https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe
Cr-Commit-Position: refs/heads/master@{#412976}
==========

[commit-bot: I haz the power, 2016-08-19 00:02:57]

Patchset 4 (id:??) landed as
https://crrev.com/b099e13e9cdd6d0380a4e915bc97f78436b73bbe
Cr-Commit-Position: refs/heads/master@{#412976}