Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: net/quic/chromium/quic_connection_logger.h

Issue 2255753003: Remove unused histograms for QUIC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove a if condition Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/chromium/quic_connection_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/quic_connection_logger.h
diff --git a/net/quic/chromium/quic_connection_logger.h b/net/quic/chromium/quic_connection_logger.h
index 55df7bf4b4ccaa2108e6a6779f6aaaaf31a3ec60..646fc8cc96ca2231cea24040d67bbd602a7a3e3c 100644
--- a/net/quic/chromium/quic_connection_logger.h
+++ b/net/quic/chromium/quic_connection_logger.h
@@ -88,39 +88,14 @@ class NET_EXPORT_PRIVATE QuicConnectionLogger
float ReceivedPacketLossRate() const;
private:
- // Do a factory get for a histogram for recording data, about individual
- // packet numbers, that was gathered in the vectors
- // received_packets_ and received_acks_. |statistic_name| identifies which
- // element of data is recorded, and is used to form the histogram name.
- base::HistogramBase* GetPacketNumberHistogram(
- const char* statistic_name) const;
// Do a factory get for a histogram to record a 6-packet loss-sequence as a
// sample. The histogram will record the 64 distinct possible combinations.
// |which_6| is used to adjust the name of the histogram to distinguish the
// first 6 packets in a connection, vs. some later 6 packets.
base::HistogramBase* Get6PacketHistogram(const char* which_6) const;
- // Do a factory get for a histogram to record cumulative stats across a 21
- // packet sequence. |which_21| is used to adjust the name of the histogram
- // to distinguish the first 21 packets' loss data, vs. some later 21 packet
- // sequences' loss data.
- base::HistogramBase* Get21CumulativeHistogram(const char* which_21) const;
- // Add samples associated with a |bit_mask_of_packets| to the given histogram
- // that was provided by Get21CumulativeHistogram(). The LSB of that mask
- // corresponds to the oldest packet number in the series of packets,
- // and the bit in the 2^20 position corresponds to the most recently received
- // packet. Of the maximum of 21 bits that are valid (correspond to packets),
- // only the most significant |valid_bits_in_mask| are processed.
- // A bit value of 0 indicates that a packet was never received, and a 1
- // indicates the packet was received.
- static void AddTo21CumulativeHistogram(base::HistogramBase* histogram,
- int bit_mask_of_packets,
- int valid_bits_in_mask);
// For connections longer than 21 received packets, this call will calculate
// the overall packet loss rate, and record it into a histogram.
void RecordAggregatePacketLossRate() const;
- // At destruction time, this records results of |pacaket_received_| into
- // histograms for specific connection types.
- void RecordLossHistograms() const;
BoundNetLog net_log_;
QuicSpdySession* session_; // Unowned.
« no previous file with comments | « no previous file | net/quic/chromium/quic_connection_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698