Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2255713002:
Use correct object in DCHECK. (Closed)
|
Created:
4 years, 4 months ago by Franzi Modified:
4 years, 4 months ago Reviewers:
Toon Verwaest CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionImprove DCHECK in DefineAccessor().
Fix getter/setter typo so we use the correct object in DCHECK.
BUG=
Committed: https://crrev.com/81ab165dafeb9bc23bf58f75ec31cd46f0739841
Cr-Commit-Position: refs/heads/master@{#38787}
Patch Set 1 #
Messages
Total messages: 24 (17 generated)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/11053)
Description was changed from ========== Use correct object in DCHECK. Check both getter and setter rather than getter twice. BUG= ========== to ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. Make DCHECK more restrictive. IsNull() is not allowed, since we check right after this DCHECk that !IsNull(). BUG= ==========
Patchset #2 (id:20001) has been deleted
Description was changed from ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. Make DCHECK more restrictive. IsNull() is not allowed, since we check right after this DCHECk that !IsNull(). BUG= ========== to ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. BUG= ==========
franzih@chromium.org changed reviewers: + verwaest@chromium.org
Hi Toon, I found a setter/getter typo. PTAL. Thanks, Franzi
lgtm
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/12872)
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. BUG= ========== to ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. BUG= ========== to ========== Improve DCHECK in DefineAccessor(). Fix getter/setter typo so we use the correct object in DCHECK. BUG= Committed: https://crrev.com/81ab165dafeb9bc23bf58f75ec31cd46f0739841 Cr-Commit-Position: refs/heads/master@{#38787} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/81ab165dafeb9bc23bf58f75ec31cd46f0739841 Cr-Commit-Position: refs/heads/master@{#38787} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
