Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/objects.cc

Issue 2255713002: Use correct object in DCHECK. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 #include <iomanip> 8 #include <iomanip>
9 #include <memory> 9 #include <memory>
10 #include <sstream> 10 #include <sstream>
(...skipping 8593 matching lines...) Expand 10 before | Expand all | Expand 10 after
8604 8604
8605 Handle<JSObject> object = Handle<JSObject>::cast(it->GetReceiver()); 8605 Handle<JSObject> object = Handle<JSObject>::cast(it->GetReceiver());
8606 // Ignore accessors on typed arrays. 8606 // Ignore accessors on typed arrays.
8607 if (it->IsElement() && object->HasFixedTypedArrayElements()) { 8607 if (it->IsElement() && object->HasFixedTypedArrayElements()) {
8608 return it->factory()->undefined_value(); 8608 return it->factory()->undefined_value();
8609 } 8609 }
8610 8610
8611 DCHECK(getter->IsCallable() || getter->IsUndefined(isolate) || 8611 DCHECK(getter->IsCallable() || getter->IsUndefined(isolate) ||
8612 getter->IsNull(isolate) || getter->IsFunctionTemplateInfo()); 8612 getter->IsNull(isolate) || getter->IsFunctionTemplateInfo());
8613 DCHECK(setter->IsCallable() || setter->IsUndefined(isolate) || 8613 DCHECK(setter->IsCallable() || setter->IsUndefined(isolate) ||
8614 setter->IsNull(isolate) || getter->IsFunctionTemplateInfo()); 8614 setter->IsNull(isolate) || setter->IsFunctionTemplateInfo());
8615 it->TransitionToAccessorProperty(getter, setter, attributes); 8615 it->TransitionToAccessorProperty(getter, setter, attributes);
8616 8616
8617 return isolate->factory()->undefined_value(); 8617 return isolate->factory()->undefined_value();
8618 } 8618 }
8619 8619
8620 8620
8621 MaybeHandle<Object> JSObject::SetAccessor(Handle<JSObject> object, 8621 MaybeHandle<Object> JSObject::SetAccessor(Handle<JSObject> object,
8622 Handle<AccessorInfo> info) { 8622 Handle<AccessorInfo> info) {
8623 Isolate* isolate = object->GetIsolate(); 8623 Isolate* isolate = object->GetIsolate();
8624 Handle<Name> name(Name::cast(info->name()), isolate); 8624 Handle<Name> name(Name::cast(info->name()), isolate);
(...skipping 11249 matching lines...) Expand 10 before | Expand all | Expand 10 after
19874 for (PrototypeIterator iter(isolate, this, kStartAtReceiver, 19874 for (PrototypeIterator iter(isolate, this, kStartAtReceiver,
19875 PrototypeIterator::END_AT_NULL); 19875 PrototypeIterator::END_AT_NULL);
19876 !iter.IsAtEnd(); iter.AdvanceIgnoringProxies()) { 19876 !iter.IsAtEnd(); iter.AdvanceIgnoringProxies()) {
19877 if (iter.GetCurrent<Object>()->IsJSProxy()) return true; 19877 if (iter.GetCurrent<Object>()->IsJSProxy()) return true;
19878 } 19878 }
19879 return false; 19879 return false;
19880 } 19880 }
19881 19881
19882 } // namespace internal 19882 } // namespace internal
19883 } // namespace v8 19883 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698